b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chris Vine <chris@cvine.freeserve.co.uk>
To: isedev@gmail.com
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	"Michael Buesch" <mb@bu3sch.de>,
	"Larry Finger" <Larry.Finger@lwfinger.net>
Subject: [RFC/RFT] b43: A fix for DMA transmission sequence errors
Date: Wed, 20 Mar 2013 13:43:02 +0000	[thread overview]
Message-ID: <20130320134302.26ea16c7@laptop.homenet> (raw)
In-Reply-To: <4518745.W5blfs9sIi@wks001.ise.net>

On Wed, 20 Mar 2013 12:26:23 +0100
ISE Development <isedev@gmail.com> wrote:

> On Friday 15 Mar 2013 11:48:42 Larry Finger wrote:
> > On 03/15/2013 01:37 AM, Rafa? Mi?ecki wrote:
> > > OK, so after early tests, this card doesn't support
> > > full-addressing at all.
> > > 
> > > I'll give this patch a try during the weekend.
> > 
> > Please follow Michael's suggestion, and change
> > 
> > 		if (slot == firstused + 2) {
> > 
> > into
> > 
> > 		if (slot == next_slot(ring, next_slot(ring,
> > firstused))) {
> > 
> > This change is needed just in case "firstused + 2" wraps around.
> > 
> > Thanks,
> > 
> > Larry
> 
> Did you get a chance to validate this patch?
> 
> So far on my system, it has been running for over week without
> problems (over 15GB of traffic).

If it helps as a data point, I have run the patch with the wrap-over
change suggested by Michael Busch and with the unlikely->likely
branching correction and it has been working fine for the last 5 days
on the 3.8.2 kernel, with approx 5GB of traffic. Before that, I put
about 10GB through the previous version of the patch as originally sent
by isedev.

Chris

  reply	other threads:[~2013-03-20 13:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 18:46 [RFC/RFT] b43: A fix for DMA transmission sequence errors Larry Finger
2013-03-14 18:55 ` Michael Büsch
2013-03-14 20:17 ` Rafał Miłecki
2013-03-15  6:37   ` Rafał Miłecki
2013-03-15 16:48     ` Larry Finger
2013-03-20 11:26       ` ISE Development
2013-03-20 13:43         ` Chris Vine [this message]
2013-03-20 14:53         ` Larry Finger
2013-03-20 15:04           ` ISE Development
2013-03-20 16:10             ` Chris Vine
2013-03-15  0:09 ` ISE Development
2013-03-15  2:07   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130320134302.26ea16c7@laptop.homenet \
    --to=chris@cvine.freeserve.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=isedev@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).