From: "Michael Büsch" <m@bues.ch>
To: b43-dev@lists.infradead.org
Subject: [PATCH] b43: use rx desc underrun interrupt
Date: Sun, 21 Apr 2013 10:44:40 +0200 [thread overview]
Message-ID: <20130421104440.48a3e006@milhouse> (raw)
In-Reply-To: <alpine.DEB.2.02.1304211006190.19161@kelly.ryd.net>
On Sun, 21 Apr 2013 10:22:51 +0200 (CEST)
Thommy Jakobsson <thommyj@gmail.com> wrote:
> The device stops sending when it hits the rx index. Thats what rx index
> is, the address after the last slot the device is allowed to use. In the
> driver it is used as the last slot handled, so if the device would
> continue it will overwrite slots that hasn't been read. So you need to
> handle that in someway. One way is using my patch, another is to never let
> it hit rx index (as Piotras is working on).
Yeah I get that. But why do we need to handle that by putting the stop index
right beyond the ring? That requires us to get another RX interrupt before the
ring fills up again. Why can't we set it so that the ring is fully writable again,
but not set it beyond the ring boundary? I guess that is decrementing it by one,
perhaps, honoring 0-index-wrapover.
> Normally the device never hit the rx index, and in such case it will just
> use the next descriptor in the table. If it finds a descriptor with END
> set, it will jump back to the beginning. Forming the ring
I know how that basic stuff works, because I wrote most of the code ;D
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20130421/59279114/attachment.sig>
next prev parent reply other threads:[~2013-04-21 8:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 8:02 [PATCH] b43: use rx desc underrun interrupt Thommy Jakobsson
2013-04-19 14:32 ` Jonas Gorski
2013-04-19 15:55 ` Michael Büsch
2013-04-19 15:59 ` Jonas Gorski
2013-04-19 18:17 ` Larry Finger
2013-04-19 18:57 ` Michael Büsch
2013-04-19 20:37 ` Thommy Jakobsson
2013-04-19 20:46 ` Michael Büsch
2013-04-19 21:05 ` Larry Finger
2013-04-19 20:30 ` Thommy Jakobsson
2013-04-20 14:14 ` Thommy
2013-04-20 18:35 ` Larry Finger
2013-04-20 22:47 ` Thommy Jakobsson
2013-04-20 19:12 ` Michael Büsch
2013-04-20 19:47 ` Thommy Jakobsson
2013-04-20 19:50 ` Michael Büsch
2013-04-20 20:16 ` Thommy Jakobsson
2013-04-20 20:38 ` Michael Büsch
2013-04-20 20:56 ` Piotras
[not found] ` <CAFzhf4rSUO9mn_RKw4Vehw2LKggFdC_W0v-K_KKCZJez1AwynQ@mail.gmail.com>
2013-04-20 21:01 ` Thommy Jakobsson
2013-04-20 21:10 ` Thommy Jakobsson
2013-04-20 21:23 ` Thommy Jakobsson
2013-04-21 6:38 ` Michael Büsch
2013-04-21 8:22 ` Thommy Jakobsson
2013-04-21 8:44 ` Michael Büsch [this message]
2013-04-21 9:01 ` Thommy Jakobsson
2013-04-21 9:21 ` Michael Büsch
2013-04-21 12:12 ` Thommy Jakobsson
2013-04-21 14:46 ` Piotras
2013-04-21 14:59 ` Michael Büsch
2013-04-21 15:24 ` Piotras
2013-04-21 16:35 ` Michael Büsch
2013-04-21 15:11 ` Thommy Jakobsson
2013-04-21 16:31 ` Michael Büsch
2013-04-21 18:07 ` Thommy Jakobsson
2013-04-21 18:26 ` Michael Büsch
2013-04-21 18:44 ` Thommy Jakobsson
[not found] ` <CAOTQ16LCWpAOndQsHBxN1-X_8SLpcU8V=mM41gvcNRocA=GhsA@mail.gmail.com>
2013-04-21 18:44 ` Michael Büsch
2013-04-21 20:13 ` Thommy Jakobsson
2013-04-21 21:53 ` Michael Büsch
2013-04-22 8:11 ` Thommy Jakobsson
2013-04-22 10:00 ` Michael Büsch
2013-04-23 6:22 ` Michael Büsch
2013-04-21 14:27 ` Piotras
2013-04-21 14:51 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421104440.48a3e006@milhouse \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).