* [PATCH] b43: Fix typo in function name
@ 2015-06-30 0:45 Nik Nyby
2015-06-30 1:29 ` Larry Finger
2015-07-21 13:53 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Nik Nyby @ 2015-06-30 0:45 UTC (permalink / raw)
To: linux-wireless, b43-dev; +Cc: Nik Nyby
This fixes a typo in the "b43_lo_g_maintenance_work" function
name.
Signed-off-by: Nik Nyby <nikolas@gnu.org>
---
drivers/net/wireless/b43/lo.c | 4 ++--
drivers/net/wireless/b43/lo.h | 2 +-
drivers/net/wireless/b43/phy_g.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
index 916123a..a335f94 100644
--- a/drivers/net/wireless/b43/lo.c
+++ b/drivers/net/wireless/b43/lo.c
@@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
b43_lo_write(dev, &cal->ctl);
}
-/* Periodic LO maintanance work */
-void b43_lo_g_maintanance_work(struct b43_wldev *dev)
+/* Periodic LO maintenance work */
+void b43_lo_g_maintenance_work(struct b43_wldev *dev)
{
struct b43_phy *phy = &dev->phy;
struct b43_phy_g *gphy = phy->g;
diff --git a/drivers/net/wireless/b43/lo.h b/drivers/net/wireless/b43/lo.h
index 3b27e20..7b4df38 100644
--- a/drivers/net/wireless/b43/lo.h
+++ b/drivers/net/wireless/b43/lo.h
@@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
-void b43_lo_g_maintanance_work(struct b43_wldev *dev);
+void b43_lo_g_maintenance_work(struct b43_wldev *dev);
void b43_lo_g_cleanup(struct b43_wldev *dev);
void b43_lo_g_init(struct b43_wldev *dev);
diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
index 727ce6e..462310e 100644
--- a/drivers/net/wireless/b43/phy_g.c
+++ b/drivers/net/wireless/b43/phy_g.c
@@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
phy->rev == 1) {
//TODO: implement rev1 workaround
}
- b43_lo_g_maintanance_work(dev);
+ b43_lo_g_maintenance_work(dev);
b43_mac_enable(dev);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] b43: Fix typo in function name
2015-06-30 0:45 [PATCH] b43: Fix typo in function name Nik Nyby
@ 2015-06-30 1:29 ` Larry Finger
2015-06-30 15:15 ` Michael Büsch
2015-07-21 13:53 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Larry Finger @ 2015-06-30 1:29 UTC (permalink / raw)
To: Nik Nyby, linux-wireless, b43-dev
On 06/29/2015 07:45 PM, Nik Nyby wrote:
> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby <nikolas@gnu.org>
> ---
> drivers/net/wireless/b43/lo.c | 4 ++--
> drivers/net/wireless/b43/lo.h | 2 +-
> drivers/net/wireless/b43/phy_g.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
This patch is OK; however, can there really be a typo in a function name? How do
you ever know that the author did not mean to use a name that looks like a typo?
Please be careful with these.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
> index 916123a..a335f94 100644
> --- a/drivers/net/wireless/b43/lo.c
> +++ b/drivers/net/wireless/b43/lo.c
> @@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
> b43_lo_write(dev, &cal->ctl);
> }
>
> -/* Periodic LO maintanance work */
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev)
> +/* Periodic LO maintenance work */
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev)
> {
> struct b43_phy *phy = &dev->phy;
> struct b43_phy_g *gphy = phy->g;
> diff --git a/drivers/net/wireless/b43/lo.h b/drivers/net/wireless/b43/lo.h
> index 3b27e20..7b4df38 100644
> --- a/drivers/net/wireless/b43/lo.h
> +++ b/drivers/net/wireless/b43/lo.h
> @@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
>
> void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
>
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev);
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev);
> void b43_lo_g_cleanup(struct b43_wldev *dev);
> void b43_lo_g_init(struct b43_wldev *dev);
>
> diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
> index 727ce6e..462310e 100644
> --- a/drivers/net/wireless/b43/phy_g.c
> +++ b/drivers/net/wireless/b43/phy_g.c
> @@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
> phy->rev == 1) {
> //TODO: implement rev1 workaround
> }
> - b43_lo_g_maintanance_work(dev);
> + b43_lo_g_maintenance_work(dev);
> b43_mac_enable(dev);
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] b43: Fix typo in function name
2015-06-30 1:29 ` Larry Finger
@ 2015-06-30 15:15 ` Michael Büsch
0 siblings, 0 replies; 4+ messages in thread
From: Michael Büsch @ 2015-06-30 15:15 UTC (permalink / raw)
To: Larry Finger; +Cc: Nik Nyby, linux-wireless, b43-dev
On Mon, 29 Jun 2015 20:29:24 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 06/29/2015 07:45 PM, Nik Nyby wrote:
> > This fixes a typo in the "b43_lo_g_maintenance_work" function
> > name.
> >
> > Signed-off-by: Nik Nyby <nikolas@gnu.org>
> > ---
> > drivers/net/wireless/b43/lo.c | 4 ++--
> > drivers/net/wireless/b43/lo.h | 2 +-
> > drivers/net/wireless/b43/phy_g.c | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
>
> This patch is OK; however, can there really be a typo in a function name? How do
> you ever know that the author did not mean to use a name that looks like a typo?
>
> Please be careful with these.
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Nice finding.
Me as the original author of that mess gets a brown paper bag and acks
this.
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20150630/4994c090/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* b43: Fix typo in function name
2015-06-30 0:45 [PATCH] b43: Fix typo in function name Nik Nyby
2015-06-30 1:29 ` Larry Finger
@ 2015-07-21 13:53 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2015-07-21 13:53 UTC (permalink / raw)
To: Nik Nyby; +Cc: linux-wireless, b43-dev
> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby <nikolas@gnu.org>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> Acked-by: Michael Buesch <m@bues.ch>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-21 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30 0:45 [PATCH] b43: Fix typo in function name Nik Nyby
2015-06-30 1:29 ` Larry Finger
2015-06-30 15:15 ` Michael Büsch
2015-07-21 13:53 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).