* [PATCH] b43: fix extpa_gain check for 2GHz
@ 2015-07-29 21:36 Hauke Mehrtens
2015-07-30 1:13 ` Rafał Miłecki
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Hauke Mehrtens @ 2015-07-29 21:36 UTC (permalink / raw)
To: kvalo; +Cc: zajec5, linux-wireless, b43-dev, Hauke Mehrtens
On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
the 5GHz band was checked. this patch makes it check the property from
the correct band.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/wireless/b43/tables_nphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/b43/tables_nphy.c b/drivers/net/wireless/b43/tables_nphy.c
index 25d1cbd..b2f0d24 100644
--- a/drivers/net/wireless/b43/tables_nphy.c
+++ b/drivers/net/wireless/b43/tables_nphy.c
@@ -3728,7 +3728,7 @@ const u32 *b43_nphy_get_tx_gain_table(struct b43_wldev *dev)
switch (phy->rev) {
case 6:
case 5:
- if (sprom->fem.ghz5.extpa_gain == 3)
+ if (sprom->fem.ghz2.extpa_gain == 3)
return b43_ntab_tx_gain_epa_rev3_hi_pwr_2g;
/* fall through */
case 4:
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] b43: fix extpa_gain check for 2GHz
2015-07-29 21:36 [PATCH] b43: fix extpa_gain check for 2GHz Hauke Mehrtens
@ 2015-07-30 1:13 ` Rafał Miłecki
2015-07-30 5:40 ` Kalle Valo
2015-07-31 6:24 ` Kalle Valo
2 siblings, 0 replies; 7+ messages in thread
From: Rafał Miłecki @ 2015-07-30 1:13 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: kvalo, linux-wireless@vger.kernel.org, b43-dev
On 29 July 2015 at 23:36, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
> the 5GHz band was checked. this patch makes it check the property from
> the correct band.
Looks OK, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] b43: fix extpa_gain check for 2GHz
2015-07-29 21:36 [PATCH] b43: fix extpa_gain check for 2GHz Hauke Mehrtens
2015-07-30 1:13 ` Rafał Miłecki
@ 2015-07-30 5:40 ` Kalle Valo
2015-07-30 6:54 ` Rafał Miłecki
2015-07-31 6:24 ` Kalle Valo
2 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2015-07-30 5:40 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: zajec5, linux-wireless, b43-dev
Hauke Mehrtens <hauke@hauke-m.de> writes:
> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
> the 5GHz band was checked. this patch makes it check the property from
> the correct band.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Is this a regression? If yes, please add a Fixes line.
Should this go to 4.2?
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] b43: fix extpa_gain check for 2GHz
2015-07-30 5:40 ` Kalle Valo
@ 2015-07-30 6:54 ` Rafał Miłecki
2015-07-30 17:34 ` Hauke Mehrtens
0 siblings, 1 reply; 7+ messages in thread
From: Rafał Miłecki @ 2015-07-30 6:54 UTC (permalink / raw)
To: Kalle Valo; +Cc: Hauke Mehrtens, linux-wireless@vger.kernel.org, b43-dev
On 30 July 2015 at 07:40, Kalle Valo <kvalo@codeaurora.org> wrote:
> Hauke Mehrtens <hauke@hauke-m.de> writes:
>
>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>> the 5GHz band was checked. this patch makes it check the property from
>> the correct band.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>
> Is this a regression? If yes, please add a Fixes line.
>
> Should this go to 4.2?
Not a regression. It's like this for a loooong time.
AFAIK PCI(e) cards don't have external power amplifier, so this code
is most likely used for some fancy SoCs only. There are 3 known SoCs
with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.
So we may consider taking it for 4.2 without any "Fixes: " line but I
wouldn't care too much about Cc-ing stable.
Hauke: do you agree?
--
Rafa?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] b43: fix extpa_gain check for 2GHz
2015-07-30 6:54 ` Rafał Miłecki
@ 2015-07-30 17:34 ` Hauke Mehrtens
2015-07-31 6:10 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Hauke Mehrtens @ 2015-07-30 17:34 UTC (permalink / raw)
To: Rafał Miłecki, Kalle Valo
Cc: linux-wireless@vger.kernel.org, b43-dev
On 07/30/2015 08:54 AM, Rafa? Mi?ecki wrote:
> On 30 July 2015 at 07:40, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>
>>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>>> the 5GHz band was checked. this patch makes it check the property from
>>> the correct band.
>>>
>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>
>> Is this a regression? If yes, please add a Fixes line.
>>
>> Should this go to 4.2?
>
> Not a regression. It's like this for a loooong time.
>
> AFAIK PCI(e) cards don't have external power amplifier, so this code
> is most likely used for some fancy SoCs only. There are 3 known SoCs
> with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.
>
> So we may consider taking it for 4.2 without any "Fixes: " line but I
> wouldn't care too much about Cc-ing stable.
>
> Hauke: do you agree?
>
Yes, I do not have a device I know of which is affected by this error, I
just saw this while looking at code close by. Just put this into the
next Linux version and not to stable.
Hauke
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] b43: fix extpa_gain check for 2GHz
2015-07-30 17:34 ` Hauke Mehrtens
@ 2015-07-31 6:10 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2015-07-31 6:10 UTC (permalink / raw)
To: Hauke Mehrtens
Cc: Rafał Miłecki, linux-wireless@vger.kernel.org, b43-dev
Hauke Mehrtens <hauke@hauke-m.de> writes:
> On 07/30/2015 08:54 AM, Rafa? Mi?ecki wrote:
>> On 30 July 2015 at 07:40, Kalle Valo <kvalo@codeaurora.org> wrote:
>>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>>
>>>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>>>> the 5GHz band was checked. this patch makes it check the property from
>>>> the correct band.
>>>>
>>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>>
>>> Is this a regression? If yes, please add a Fixes line.
>>>
>>> Should this go to 4.2?
>>
>> Not a regression. It's like this for a loooong time.
>>
>> AFAIK PCI(e) cards don't have external power amplifier, so this code
>> is most likely used for some fancy SoCs only. There are 3 known SoCs
>> with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.
>>
>> So we may consider taking it for 4.2 without any "Fixes: " line but I
>> wouldn't care too much about Cc-ing stable.
>>
>> Hauke: do you agree?
>
> Yes, I do not have a device I know of which is affected by this error, I
> just saw this while looking at code close by. Just put this into the
> next Linux version and not to stable.
Ok, I'll send this to 4.2.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* b43: fix extpa_gain check for 2GHz
2015-07-29 21:36 [PATCH] b43: fix extpa_gain check for 2GHz Hauke Mehrtens
2015-07-30 1:13 ` Rafał Miłecki
2015-07-30 5:40 ` Kalle Valo
@ 2015-07-31 6:24 ` Kalle Valo
2 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2015-07-31 6:24 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: kvalo, zajec5, linux-wireless, b43-dev
> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
> the 5GHz band was checked. this patch makes it check the property from
> the correct band.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Thanks, applied to wireless-drivers.git.
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-31 6:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-29 21:36 [PATCH] b43: fix extpa_gain check for 2GHz Hauke Mehrtens
2015-07-30 1:13 ` Rafał Miłecki
2015-07-30 5:40 ` Kalle Valo
2015-07-30 6:54 ` Rafał Miłecki
2015-07-30 17:34 ` Hauke Mehrtens
2015-07-31 6:10 ` Kalle Valo
2015-07-31 6:24 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).