From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Thu, 2 Jul 2020 08:21:40 -0700 Subject: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage In-Reply-To: <20200701203920.GC3776@sirena.org.uk> References: <20200620033007.1444705-1-keescook@chromium.org> <20200620033007.1444705-9-keescook@chromium.org> <20200701203920.GC3776@sirena.org.uk> Message-ID: <202007020819.318824DA@keescook> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown Cc: linux-kernel@vger.kernel.org, Nick Desaulniers , Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings (e.g. > > "unused variable"). If the compiler thinks it is uninitialized, either > > simply initialize the variable or make compiler changes. As a precursor > > to removing[2] this[3] macro[4], just remove this variable since it was > > actually unused: > > Please copy maintainers on patches :( Hi! Sorry about that; the CC list was giant, so I had opted for using subsystem mailing lists where possible. > Acked-by: Mark Brown Thanks! -- Kees Cook