From: "Michael Büsch" <m@bues.ch>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: Larry.Finger@lwfinger.net, kvalo@kernel.org,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next] wifi: b43legacy: clean up some inconsistent indentings
Date: Wed, 20 Dec 2023 10:23:07 +0100 [thread overview]
Message-ID: <20231220102307.7dd1f187@barney> (raw)
In-Reply-To: <20231220011209.127586-1-yang.lee@linux.alibaba.com>
[-- Attachment #1.1: Type: text/plain, Size: 1358 bytes --]
On Wed, 20 Dec 2023 09:12:09 +0800
Yang Li <yang.lee@linux.alibaba.com> wrote:
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7783
This link is not publicly accessible.
> a/drivers/net/wireless/broadcom/b43legacy/dma.c +++
> b/drivers/net/wireless/broadcom/b43legacy/dma.c @@ -174,8 +174,8 @@
> static struct b43legacy_dmaring *priority_to_txring( {
> struct b43legacy_dmaring *ring;
>
> -/*FIXME: For now we always run on TX-ring-1 */
> -return dev->dma.tx_ring1;
> + /*FIXME: For now we always run on TX-ring-1 */
> + return dev->dma.tx_ring1;
>
> /* 0 = highest priority */
> switch (queue_priority) {
Thanks for your patch.
But actually, I am kind of annoyed by the constant stream of whitespace
fixing and dead code removal and other trivial changes to this legacy
driver.
It does not improve the code to add two tabs to this _ancient_ code.
And I can already see the next patch coming that removes the dead code
after this FIXME return. And then the next patch will come to remove
this function altogether, and so on and so on.
This driver has a _lot_ of such code, because it is based on reverse
engineered knowledge with many many unknowns.
IMO this just creates additional maintenance work and pressure on our
maintainers for no good reason.
--
Michael Büsch
https://bues.ch/
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
next prev parent reply other threads:[~2023-12-20 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 1:12 [PATCH net-next] wifi: b43legacy: clean up some inconsistent indentings Yang Li
2023-12-20 5:14 ` Kalle Valo
2023-12-20 9:23 ` Michael Büsch [this message]
2024-01-13 16:46 ` wireless: cleanup patches Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220102307.7dd1f187@barney \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=abaci@linux.alibaba.com \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).