From: "Michael Büsch" <m@bues.ch>
To: Andreas Wendleder <gonsolo@gmail.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org, johannes@sipsolutions.net,
stable@vger.kernel.org
Subject: Re: [PATCH] wifi: b43: fix use-after-free in b43_bcma_remove()
Date: Tue, 13 Oct 2026 19:16:31 +0200 [thread overview]
Message-ID: <20261013191631.3bd9e1e9@barney> (raw)
In-Reply-To: <20261013000124.48605-1-gonsolo@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1062 bytes --]
On Tue, 13 Oct 2026 02:01:24 +0200
Andreas Wendleder <gonsolo@gmail.com> wrote:
> --- a/drivers/net/wireless/broadcom/b43/main.c
> +++ b/drivers/net/wireless/broadcom/b43/main.c
> @@ -5677,6 +5677,7 @@ static void b43_bcma_remove(struct bcma_device *core)
> {
> struct b43_wldev *wldev = bcma_get_drvdata(core);
> struct b43_wl *wl = wldev->wl;
> + struct b43_bus_dev *dev = wldev->dev;
>
> /* We must cancel any work here before unregistering from ieee80211,
> * as the ieee80211 unreg will destroy the workqueue. */
> @@ -5691,14 +5692,14 @@ static void b43_bcma_remove(struct bcma_device *core)
> ieee80211_unregister_hw(wl->hw);
> }
>
> - b43_one_core_detach(wldev->dev);
> + b43_one_core_detach(dev);
>
> /* Unregister HW RNG driver */
> b43_rng_exit(wl);
>
> b43_leds_unregister(wl);
> ieee80211_free_hw(wl->hw);
> - kfree(wldev->dev);
> + kfree(dev);
> }
>
> static struct bcma_driver b43_bcma_driver = {
Reviewed-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
prev parent reply other threads:[~2026-10-13 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 0:01 [PATCH] wifi: b43: fix use-after-free in b43_bcma_remove() Andreas Wendleder
2026-10-13 0:16 ` Andreas Wendleder
2026-10-13 17:16 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013191631.3bd9e1e9@barney \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=gonsolo@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).