From: Florian Fainelli <florian@openwrt.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, zajec5@gmail.com,
b43-dev@lists.infradead.org, arend@broadcom.com,
linux-wireless@vger.kernel.org
Subject: [PATCH 3/8] bcma: Fix for 4329b0 bad LPOM is detection
Date: Wed, 06 Jun 2012 10:08:15 +0200 [thread overview]
Message-ID: <2043822.26J1ek8FFi@flexo> (raw)
In-Reply-To: <1338933307-13446-4-git-send-email-hauke@hauke-m.de>
Hi Hauke,
On Tuesday 05 June 2012 23:55:02 Hauke Mehrtens wrote:
> This workaround should be triggered based on the chipid and rev and not
> the core id and rev. This is based on code in the Broadcom SDK.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/bcma/driver_chipcommon_pmu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bcma/driver_chipcommon_pmu.c
b/drivers/bcma/driver_chipcommon_pmu.c
> index da8769e..dd2b55d 100644
> --- a/drivers/bcma/driver_chipcommon_pmu.c
> +++ b/drivers/bcma/driver_chipcommon_pmu.c
> @@ -166,6 +166,7 @@ static void bcma_pmu_workarounds(struct bcma_drv_cc *cc)
> void bcma_pmu_init(struct bcma_drv_cc *cc)
> {
> u32 pmucap;
> + struct bcma_bus *bus = cc->core->bus;
>
> pmucap = bcma_cc_read32(cc, BCMA_CC_PMU_CAP);
> cc->pmu.rev = (pmucap & BCMA_CC_PMU_CAP_REVISION);
> @@ -180,7 +181,7 @@ void bcma_pmu_init(struct bcma_drv_cc *cc)
> bcma_cc_set32(cc, BCMA_CC_PMU_CTL,
> BCMA_CC_PMU_CTL_NOILPONW);
>
> - if (cc->core->id.id == 0x4329 && cc->core->id.rev == 2)
> + if (bus->chipinfo.id == 0x4329 && bus->chipinfo.rev == 2)
> pr_err("Fix for 4329b0 bad LPOM state not implemented!\n");
Does not that deserve a new define to be in line with your previous patch?
--
Florian
next prev parent reply other threads:[~2012-06-06 8:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 21:54 [PATCH 0/8] bcma misc updates Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 1/8] bcma: extend workaround for bcm4331 Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 2/8] bcma: add constants for chip ids Hauke Mehrtens
2012-06-06 11:51 ` Arend van Spriel
2012-06-05 21:55 ` [PATCH 3/8] bcma: Fix for 4329b0 bad LPOM is detection Hauke Mehrtens
2012-06-06 8:08 ` Florian Fainelli [this message]
2012-06-06 8:42 ` Hauke Mehrtens
2012-06-06 11:45 ` Arend van Spriel
2012-06-05 21:55 ` [PATCH 4/8] bcma: add PCI ID for BCM43224 Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 5/8] bcma: complete workaround for BCMA43224 and BCM4313 Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 6/8] bcma: handle SoCs in pmu initialization Hauke Mehrtens
2012-06-06 12:19 ` Florian Fainelli
2012-06-07 12:59 ` Hauke Mehrtens
2012-06-10 16:54 ` Rafał Miłecki
2012-06-10 19:37 ` Hauke Mehrtens
2012-06-28 15:52 ` Rafał Miłecki
2012-06-28 18:14 ` Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 7/8] bcma: add bcma_pmu_spuravoid_pllupdate() Hauke Mehrtens
2012-06-10 16:53 ` Rafał Miłecki
2012-06-10 19:34 ` Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 8/8] bcma: add mdelay bcma_pmu_resources_init() Hauke Mehrtens
2012-06-29 7:44 ` [PATCH 0/8] bcma misc updates Rafał Miłecki
2012-06-29 13:37 ` John W. Linville
2012-06-29 16:40 ` Hauke Mehrtens
2012-06-29 19:33 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2043822.26J1ek8FFi@flexo \
--to=florian@openwrt.org \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).