From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Joe Perches" <joe@perches.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"Michael Büsch" <mb@bu3sch.de>,
"Arend van Spriel" <arend@broadcom.com>,
"George Kashperko" <george@znau.edu.ua>,
b43-dev@lists.infradead.org
Subject: [RFC][PATCH] bcmai: introduce AI driver
Date: Tue, 05 Apr 2011 15:50:10 -0500 [thread overview]
Message-ID: <4D9B8082.10201@lwfinger.net> (raw)
In-Reply-To: <BANLkTimTmqop-xzFsWr1=2RXv5z6iTre4Q@mail.gmail.com>
On 04/05/2011 03:15 PM, Rafa? Mi?ecki wrote:
>
> I was reading about __packed long time ago and it was a little tricky
> for me. However I don't see anything in mod_devicetable.h using that
> __packed. Why should we?
Packed should only be used for those structs that are read/written by some
entity other than the main CPU. For example, RX and TX descriptors must be
packed. Otherwise, you should let the compiler align them any way that it thinks
might be more efficient. If that requires holes to aligh a 16-bit quantity, let
it. Of course, it would not make any difference for x86 on this one, but for
some architectures (ARM, I think is one), the system must do byte accesses for
all entries in a packed struct, just in case they are unaligned.
Larry
next prev parent reply other threads:[~2011-04-05 20:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 19:57 [RFC][PATCH] bcmai: introduce AI driver Rafał Miłecki
2011-04-05 19:25 ` Rafał Miłecki
2011-04-05 19:29 ` Michael Büsch
[not found] ` <1302032137.3969.10.camel@Joe-Laptop>
2011-04-05 20:15 ` Rafał Miłecki
2011-04-05 20:25 ` Michael Büsch
2011-04-05 20:50 ` Larry Finger [this message]
[not found] ` <op.vtisojsk3ri7v4@arend-laptop>
2011-04-06 18:02 ` Rafał Miłecki
[not found] ` <op.vti9ote53ri7v4@arend-laptop>
2011-04-06 20:40 ` Rafał Miłecki
2011-04-06 20:42 ` Rafał Miłecki
2011-04-06 20:57 ` Michael Büsch
2011-04-06 21:01 ` Rafał Miłecki
2011-04-06 21:08 ` Michael Büsch
2011-04-06 21:12 ` Rafał Miłecki
2011-04-06 21:20 ` Michael Büsch
[not found] ` <1302124737.27258.7.camel@dev.znau.edu.ua>
2011-04-06 23:20 ` Rafał Miłecki
[not found] ` <1302134429.27258.32.camel@dev.znau.edu.ua>
2011-04-07 0:54 ` Rafał Miłecki
2011-04-07 7:54 ` Michael Büsch
2011-04-07 9:55 ` Rafał Miłecki
2011-04-08 16:56 ` Rafał Miłecki
2011-04-08 17:09 ` Rafał Miłecki
2011-04-08 17:14 ` Rafał Miłecki
[not found] ` <op.vtmqm7fw3ri7v4@arend-laptop>
2011-04-08 17:27 ` Rafał Miłecki
[not found] ` <op.vtmqujir3ri7v4@arend-laptop>
2011-04-08 17:31 ` Rafał Miłecki
[not found] ` <20110410080159.GB2798@ucw.cz>
2011-04-10 8:05 ` Rafał Miłecki
[not found] ` <20110410082420.GA1460@localhost.ucw.cz>
2011-04-10 8:30 ` Rafał Miłecki
[not found] ` <op.vtpt6v173ri7v4@arend-laptop>
2011-04-10 11:32 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B8082.10201@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=george@znau.edu.ua \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).