From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Date: Tue, 16 Aug 2011 16:47:56 -0500 Subject: [PATCH V2] b43: warn when forcing PIO mode In-Reply-To: <1313523861-2526-1-git-send-email-zajec5@gmail.com> References: <1313523861-2526-1-git-send-email-zajec5@gmail.com> Message-ID: <4E4AE58C.3030008@lwfinger.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org, Gregory Bellier On 08/16/2011 02:44 PM, Rafa? Mi?ecki wrote: > We have resolved all the known issues with DMA mode, however some users > (or distros) are still forcing PIO mode by config files. Without > debugging enabled it's not noticable at all. Add the warning for them. > > Cc: Gregory Bellier > Signed-off-by: Rafa? Mi?ecki ACKed-by: Larry Finger > --- > V2: typo in "parameter". I have to install spell checker for vim ;) > Thx Gregory. > --- > drivers/net/wireless/b43/main.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c > index 1adadc8..e0b1156 100644 > --- a/drivers/net/wireless/b43/main.c > +++ b/drivers/net/wireless/b43/main.c > @@ -4636,8 +4636,13 @@ static int b43_wireless_core_init(struct b43_wldev *dev) > b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MAXCONT, 0x3FF); > > if (b43_bus_host_is_pcmcia(dev->dev) || > - b43_bus_host_is_sdio(dev->dev) || > - dev->use_pio) { > + b43_bus_host_is_sdio(dev->dev)) { > + dev->__using_pio_transfers = 1; > + err = b43_pio_init(dev); > + } else if (dev->use_pio) { > + b43warn(dev->wl, "Forced PIO by use_pio module parameter. " > + "This should not be needed and will result in lower " > + "performance.\n"); > dev->__using_pio_transfers = 1; > err = b43_pio_init(dev); > } else {