From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Date: Sat, 08 Oct 2011 18:00:07 -0500 Subject: [PATCH] ssb: Convert to use crc8 code in kernel library In-Reply-To: <1318113514.1844.34.camel@Joe-Laptop> References: <4e90ce9a.89uGF659NNpbpyA3%Larry.Finger@lwfinger.net> <1318113514.1844.34.camel@Joe-Laptop> Message-ID: <4E90D5F7.6020005@lwfinger.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: John W Linville , Michael Buesch , zajec5@gmail.com, b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org On 10/08/2011 05:38 PM, Joe Perches wrote: > On Sat, 2011-10-08 at 17:28 -0500, Larry Finger wrote: >> The kernel now contains library routines to establish crc8 tables and >> to calculate the appropriate sums. Use them for ssb. > [] >> --- wireless-testing-new.orig/drivers/ssb/pci.c > [] >> +static inline void ltoh16_buf(u16 *buf, unsigned int size) > > Perhaps a rename and use le16_to_cpup? > >> +static inline void htol16_buf(u16 *buf, unsigned int size) > > and cpu_to_le16p? I'm sorry, but I don't see any advantage to using a pointer version here. Please enlighten me. Thanks, Larry