[PATCH] b43: ensure ext PA lines are enabled for BCM4331

Arend van Spriel
2012-05-31T17:43:38Z

On 05/31/2012 04:26 PM, Seth Forshee wrote:
> On Thu, May 31, 2012 at 04:16:05PM +0200, Hauke Mehrtens wrote:
>> > Hi Seth,
>> >
>> > why don't you call this from bcma_pmu_workarounds() in
>> > drivers/bcma/driver_chipcommon_pmu.c instead of calling this from b43? I
>> > think it looks better to call some workarounds on chip common from bcma
>> > and not from b43.
> Arend recommended calling it from within b43's start op, but I'm not
> sure of the reason. Arend?

Well, my comment on start op was regarding your observation of CHIPCTL
being zero. As the start op does reinitialize the hardware you should
check CHIPCTL register at the end of it. This is just to confirm the
register contains valid bits.

> Agreed though that if there's no need to run it every time the interface
> is started then bcma_pmu_workarounds() would be a nicer place for it.
>

So I agree with Hauke and have this code in bcma. Just not sure whether
bcma_pmu_workarounds() is the place to put it. This is not a pmu related
register, but as the function was already there I will not stress to
move it to driver_chipcommon.c ;-)

Gr. AvS