From: Arend van Spriel <arend@broadcom.com>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, ath5k-devel@lists.ath5k.org,
ilw@linux.intel.com, users@rt2x00.serialmonkey.com,
b43-dev@lists.infradead.org, brcm80211-dev-list@broadcom.com,
chunkeey@googlemail.com, buytenh@wantstofly.org, dsd@gentoo.org,
coelho@ti.com, johannes.berg@intel.com
Subject: [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Sat, 14 Jul 2012 12:10:08 +0200 [thread overview]
Message-ID: <50014580.7060702@broadcom.com> (raw)
In-Reply-To: <1342205545-45382-3-git-send-email-thomas@net.t-labs.tu-berlin.de>
On 07/13/2012 08:52 PM, Thomas Huehn wrote:
> The pointer control.sta is removed from ieee80211_tx_info to free up sufficient
> memory in SKB_CB on the tx-path to enable new annotations per data packet e.g.
> support of upcoming Transmit Power Control (TPC).
> Now the control.sta pointer is put on the stack where it is passed as function
> parameter to the .tx equivalent (ieee80211_ops) of each affected wireless
> driver. Therefore a new structure ieee80211_tx_control is added to mac80211.h
> which holds the sta structure instead.
>
> ---
> .../net/wireless/brcm80211/brcmsmac/mac80211_if.c | 6 +++--
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
> index 9e79d47..a7be68d 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
> @@ -264,7 +264,9 @@ static void brcms_set_basic_rate(struct brcm_rateset *rs, u16 rate, bool is_br)
> }
> }
>
> -static void brcms_ops_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
> +static void brcms_ops_tx(struct ieee80211_hw *hw,
> + struct ieee80211_tx_control *control,
> + struct sk_buff *skb)
Fix indent here (if it is not a mailer issue).
> {
> struct brcms_info *wl = hw->priv;
> struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
> @@ -276,7 +278,7 @@ static void brcms_ops_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
> goto done;
> }
> brcms_c_sendpkt_mac80211(wl->wlc, skb, hw);
> - tx_info->rate_driver_data[0] = tx_info->control.sta;
> + tx_info->rate_driver_data[0] = control->sta;
> done:
> spin_unlock_bh(&wl->lock);
> }
Gr. AvS
next prev parent reply other threads:[~2012-07-14 10:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 18:52 mac80211: Restructure ieee80211_tx_info->control to gain free space along tx-path Thomas Huehn
2012-07-13 18:52 ` [PATCH 1/2] mac80211_hwsim: fix possible race condition in usage of info->control.sta & control.vif Thomas Huehn
2012-07-13 18:52 ` [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path Thomas Huehn
2012-07-14 10:10 ` Arend van Spriel [this message]
2012-07-14 11:44 ` [ath9k-devel] " Felix Fietkau
2012-07-14 12:55 ` Arend van Spriel
2012-07-15 4:49 ` Luciano Coelho
2012-07-17 9:44 ` Johannes Berg
2012-07-17 12:57 ` [ath5k-devel] " Thomas Huehn
2012-07-17 13:03 ` Johannes Berg
2012-07-17 20:33 ` Thomas Huehn
2012-07-18 6:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50014580.7060702@broadcom.com \
--to=arend@broadcom.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=buytenh@wantstofly.org \
--cc=chunkeey@googlemail.com \
--cc=coelho@ti.com \
--cc=dsd@gentoo.org \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@net.t-labs.tu-berlin.de \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).