From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH 1/2] b43: mark some functions and structs static
Date: Wed, 27 Mar 2013 18:53:31 +0100 [thread overview]
Message-ID: <5153321B.5010206@hauke-m.de> (raw)
In-Reply-To: <CACna6ryua5Bok2w1B4g1C6_tyqkAbBT6B+7GjBARH02s70ua+A@mail.gmail.com>
On 03/27/2013 06:43 PM, Rafa? Mi?ecki wrote:
> 2013/3/27 John W. Linville <linville@tuxdriver.com>:
>> On Wed, Mar 27, 2013 at 05:15:50PM +0100, Hauke Mehrtens wrote:
>>> This fixes some sparse warnings.
>>>
>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>> ---
>>> drivers/net/wireless/b43/phy_n.c | 6 ++++--
>>> drivers/net/wireless/b43/radio_2056.c | 2 +-
>>> drivers/net/wireless/b43/sdio.h | 4 ++--
>>> drivers/net/wireless/b43/tables_nphy.c | 4 ++--
>>> drivers/net/wireless/b43/tables_phy_lcn.c | 6 +++---
>>> 5 files changed, 12 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
>>> index 1ec0d69..8d15878 100644
>>> --- a/drivers/net/wireless/b43/phy_n.c
>>> +++ b/drivers/net/wireless/b43/phy_n.c
>>> @@ -2789,9 +2789,11 @@ static void b43_nphy_iq_cal_gain_params(struct b43_wldev *dev, u16 core,
>>> * Tx and Rx
>>> **************************************************/
>>>
>>> -void b43_nphy_set_rxantenna(struct b43_wldev *dev, int antenna)
>>> +#if 0
>>> +static void b43_nphy_set_rxantenna(struct b43_wldev *dev, int antenna)
>>> {//TODO
>>> }
>>> +#endif
>>>
>>> static void b43_nphy_op_adjust_txpower(struct b43_wldev *dev)
>>> {//TODO
>>
>> If this isn't necessary, why not just remove it?
>
> They are used for pointers that AFAIR can't be null.
The set_rx_antenna is not set for the n-phy and it is checked for null
before calling it and b43_nphy_set_rxantenna() is not referenced, so it
could be removed. The others are probably needed.
Hauke
next prev parent reply other threads:[~2013-03-27 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 16:15 [PATCH 1/2] b43: mark some functions and structs static Hauke Mehrtens
2013-03-27 16:15 ` [PATCH 2/2] b43: make struct b2056_inittabs_pts const Hauke Mehrtens
2013-03-27 17:27 ` [PATCH 1/2] b43: mark some functions and structs static John W. Linville
2013-03-27 17:43 ` Rafał Miłecki
2013-03-27 17:53 ` Hauke Mehrtens [this message]
2013-03-28 10:00 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5153321B.5010206@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox