From mboxrd@z Thu Jan 1 00:00:00 1970 From: nick Date: Sat, 29 Nov 2014 13:09:09 -0500 Subject: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c In-Reply-To: References: <1417213013-19758-1-git-send-email-xerofoify@gmail.com> <20141129002148.1beb21d9@wiggum> <54793E4E.7050602@gmail.com> <20141129095632.69361457@wiggum> Message-ID: <547A0BC5.2080005@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?B?TWljaGE=?= =?UTF-8?B?ZWwgQsO8c2No?= Cc: Network Development , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , Stefano Brivio , b43-dev Sorry about that, next time I will be more careful. Nick On 2014-11-29 04:04 AM, Rafa? Mi?ecki wrote: > On 29 November 2014 at 09:56, Michael B?sch wrote: >> On Fri, 28 Nov 2014 22:32:30 -0500 >> nick wrote: >> >>> I don't have hardware for this driver on me, so I didn't test it. However this seems to >>> be correct from my reading of the code around this function and other locking related >>> to this driver. >> >> From the current docs: >> >>> * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit >>> * must be set or cleared for a given STA. Must be atomic. >> >> So it is not allowed to lock a mutex here. > > Nicholas please be more careful with your patches. It seems your patch > is wrong, you didn't check the docs and you didn't even say in the > first place that it wasn't tested. You could at least submit with with > RFT tag or sth. >