From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Date: Mon, 8 Feb 2016 15:44:51 -0600 Subject: [PATCH 2/2] rtlwifi: Remove unnecessary synchronize_irq() before free_irq() In-Reply-To: <1454964073-25108-2-git-send-email-lars@metafoo.de> References: <1454964073-25108-1-git-send-email-lars@metafoo.de> <1454964073-25108-2-git-send-email-lars@metafoo.de> Message-ID: <56B90C53.3070204@lwfinger.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lars-Peter Clausen , Kalle Valo Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Chaoming Li , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org On 02/08/2016 02:41 PM, Lars-Peter Clausen wrote: > Calling synchronize_irq() right before free_irq() is quite useless. On one > hand the IRQ can easily fire again before free_irq() is entered, on the > other hand free_irq() itself calls synchronize_irq() internally (in a race > condition free way), before any state associated with the IRQ is freed. > > Patch was generated using the following semantic patch: > // > @@ > expression irq; > @@ > -synchronize_irq(irq); > free_irq(irq, ...); > // > > Signed-off-by: Lars-Peter Clausen > --- > drivers/net/wireless/realtek/rtlwifi/pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c > index 7f471bf..140d254 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c > @@ -2392,7 +2392,6 @@ void rtl_pci_disconnect(struct pci_dev *pdev) > rtlpriv->cfg->ops->deinit_sw_vars(hw); > > if (rtlpci->irq_alloc) { > - synchronize_irq(rtlpci->pdev->irq); > free_irq(rtlpci->pdev->irq, hw); > rtlpci->irq_alloc = 0; > } > Acked-by: Larry Finger Makes sense to me. Thanks, Larry