From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 08 Jan 2018 19:06:24 +0200 Subject: b43: Replace mdelay with msleep in b43_radio_2057_init_post In-Reply-To: (Larry Finger's message of "Mon, 8 Jan 2018 10:31:56 -0600") References: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> <20180108162128.6D37560B1D@smtp.codeaurora.org> Message-ID: <87shbg2sbz.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Larry Finger Cc: Jia-Ju Bai , kstewart@linuxfoundation.org, johannes.berg@intel.com, tiwai@suse.de, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, andrew.zaborowski@intel.com, b43-dev@lists.infradead.org, netdev@vger.kernel.org, colin.king@canonical.com Larry Finger writes: > On 01/08/2018 10:21 AM, Kalle Valo wrote: >> Jia-Ju Bai wrote: >> >>> b43_radio_2057_init_post is not called in an interrupt handler >>> nor holding a spinlock. >>> The function mdelay in it can be replaced with msleep, to reduce busy wait. >>> >>> Signed-off-by: Jia-Ju Bai >> >> You submitted an identical patch a week earlier: >> >> https://patchwork.kernel.org/patch/10137671/ >> >> How is this different? Also always add version number to the patch so that the >> maintainers can follow the changes easily: >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing > > I had negative comments on one of those due to the possibility of > msleep(2) extending as long as 20 msec. Until the author, or someone > else, can test that this is OK, then the mdelay(2) can only be > replaced with usleep_range(2000, 3000). > > NACK for both. Ok, patches dropped. -- Kalle Valo