From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 27 Aug 2020 10:42:12 +0300 Subject: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements In-Reply-To: <20200817085018.GT4354@dell> (Lee Jones's message of "Mon, 17 Aug 2020 09:50:18 +0100") References: <20200814113933.1903438-1-lee.jones@linaro.org> <20200814113933.1903438-8-lee.jones@linaro.org> <87v9hll0ro.fsf@codeaurora.org> <20200814164322.GP4354@dell> <87eeo9kulw.fsf@codeaurora.org> <20200817085018.GT4354@dell> Message-ID: <87zh6gleln.fsf@codeaurora.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, Martin Langer , Stefano Brivio , Michael Buesch , van Dyk , Andreas Jaggi , Albert Herranz , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org Lee Jones writes: > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > On Fri, 14 Aug 2020, Kalle Valo wrote: >> > >> >> Lee Jones writes: >> >> >> >> > Fixes the following W=1 kernel build warning(s): >> >> > >> >> > drivers/net/wireless/broadcom/b43/main.c: In function ?b43_dummy_transmission?: >> >> > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest >> >> > braces around empty body in an ?if? statement [-Wempty-body] >> >> > drivers/net/wireless/broadcom/b43/main.c: In function ?b43_do_interrupt_thread?: >> >> > drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest >> >> > braces around empty body in an ?if? statement [-Wempty-body] >> >> > >> >> > Cc: Kalle Valo >> >> > Cc: "David S. Miller" >> >> > Cc: Jakub Kicinski >> >> > Cc: Martin Langer >> >> > Cc: Stefano Brivio >> >> > Cc: Michael Buesch >> >> > Cc: van Dyk >> >> > Cc: Andreas Jaggi >> >> > Cc: Albert Herranz >> >> > Cc: linux-wireless at vger.kernel.org >> >> > Cc: b43-dev at lists.infradead.org >> >> > Cc: netdev at vger.kernel.org >> >> > Signed-off-by: Lee Jones >> >> > --- >> >> > drivers/net/wireless/broadcom/b43/main.c | 6 ++++-- >> >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> >> >> >> Please don't copy the full directory structure to the title. I'll change >> >> the title to more simple version: >> >> >> >> b43: add braces around empty statements >> > >> > This seems to go the other way. >> > >> > "net: wireless: b43" seems sensible. >> >> Sorry, not understanding what you mean here. > > So I agree that: > > "net: wireless: broadcom: b43: main" > > ... seems unnecessarily long and verbose. However, IMHO: > > "b43:" > > ... is too short and not forthcoming enough. Obviously this fine when > something like `git log -- net/wireless`, as you already know what the > patch pertains to, however when someone who is not in the know (like I > would be) does `git log` and sees a "b43:" patch, they would have no > idea which subsystem this patch is adapting. Even: > > "wireless: b43:" > > ... would be worlds better. > > A Git log which omitted all subsystem tags would be of limited use. There are good reasons why the style is like it is. If I would start adding "wireless:" tags to the title it would clutter 'git log --oneline' and gitk output, which I use all the time. And I'm not interested making my work harder, there would need to be really strong reasons why I would even recondiser changing it. BTW, this is also documented in our wiki: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches