From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Fri, 18 Mar 2011 23:42:20 +0100 Subject: [RFC][PATCH] ssb: separate common scanning functions In-Reply-To: <1300483139.15919.42.camel@dev.znau.edu.ua> References: <1300449773-11255-1-git-send-email-zajec5@gmail.com> <1300453433.13499.18.camel@dev.znau.edu.ua> <1300460342.13499.60.camel@dev.znau.edu.ua> <1300483139.15919.42.camel@dev.znau.edu.ua> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: George Kashperko Cc: linux-wireless@vger.kernel.org, "John W. Linville" , =?UTF-8?Q?Michael_B=C3=BCsch?= , b43-dev@lists.infradead.org 2011/3/18 George Kashperko : > Well, I see this as following. In generic host life time there are > several states. These states are following: > 1. Host just started up, underlying backplane is powered up, we issued > backplane detect/scan. At this point at least some minimal windowed > access is up (if such required), not yet cores/devices are known. > 2. Backplane got identified, scanned, individual cores/devices > recognised, buscommon and buscore are registered with kernel to get them > matched with drivers, and then probed and set up. > 3. Buscommon and buscore are driven, host can finish with host specific > workarounds, both buscommon and buscore can get their _init entry points > called, we can setup host device irq routine, finally we can expose the > rest cores/devices to kernel. > > With that in mind here is my general host ops design pseudo code: > struct host_ops { > ? ? ? ?/* Init call we should get once both buscommon and buscore drivers are bound (state #3) */ > ? ? ? ?int (*init)(struct bcmb_bus *bus); > > ? ? ? ?/* Regular backplane access ops */ > ? ? ? ?u8 (*read(8|16|32))(struct bcmb_bus *bus, bcmb_addr_t addr); > ? ? ? ?void (*write(8|16|32))(struct bcmb_bus *bus, bcmb_addr_t addr, u(8|16|32) val); > > ? ? ? ?/* For some theoretically hard-to-set-up before scan hosts we could keep scan_read32 */ > ? ? ? ?u32 scan_read32(struct bcmb_bus *bus, bcmb_addr_t addr); > }; I don't think it makes much sense. If init is going to be called in state #3, what about some pre-init? set_master, request_region, xtal, iomap? -- Rafa?