From: "Rafał Miłecki" <zajec5@gmail.com>
To: "Michael Büsch" <mb@bu3sch.de>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [RFC][PATCH] b43: rfkill: use HI enabled bit for all devices
Date: Wed, 17 Nov 2010 22:02:17 +0100 [thread overview]
Message-ID: <AANLkTinLu4-VyZ9cePjgMb1sU12MmB8SG=BL4_8P=4x0@mail.gmail.com> (raw)
In-Reply-To: <1290025798.2513.74.camel@maggie>
W dniu 17 listopada 2010 21:29 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> On Wed, 2010-11-17 at 21:23 +0100, Rafa? Mi?ecki wrote:
>> >> ?/* Returns TRUE, if the radio is enabled in hardware. */
>> >> -bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
>> >> +inline bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
>> >
>> > inline doesn't make sense here.
>>
>> Err, tip for compiler for optimization? To avoid some JUMPs in generated ASM?
>
> Inline doesn't really work that way. In this case it might generate
> an inline version for callers inside of rfkill.c and an
> always-out-of-line version for other callers.
> If you really want it inline (Which I think isn't really necessary
> as this isn't a fastpath), you'll need to make it static inline
> and put it into rfkill.h
Huh, I got no idea inline works differently for local calls and calls
from other files. That's tricky.
Thanks, I'll send V2.
--
Rafa?
prev parent reply other threads:[~2010-11-17 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 19:56 [RFC][PATCH] b43: rfkill: use HI enabled bit for all devices Rafał Miłecki
2010-11-17 20:17 ` Michael Büsch
2010-11-17 20:23 ` Rafał Miłecki
2010-11-17 20:29 ` Michael Büsch
2010-11-17 21:02 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinLu4-VyZ9cePjgMb1sU12MmB8SG=BL4_8P=4x0@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).