From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Fri, 8 Apr 2011 19:09:03 +0200 Subject: [RFC][PATCH] bcmai: introduce AI driver In-Reply-To: References: <1302033463-1846-1-git-send-email-zajec5@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org 2011/4/8 Rafa? Mi?ecki : > 2011/4/6 Arend van Spriel : >> 3. Device identification >> >> The cores are identified by manufacturer, core id and revision in your >> patch. I would not use the revision because 4 out of 5 times a revision >> change does indicate a hardware change but no change in programming >> interface. The enumeration data does contain a more selective field >> indicating the core class (4 bits following the core identifier). I suggest >> to replace the revision field by this class field. > > Could you say something more about *class*, please? For my BCM43224 it > seems to be 0x0. WIll check BCM4313 in a moment. Same for BCM4313. BCM43224: axi: Core 0 found: ChipCommon (manuf 0x4BF, id 0x800, rev 0x22, class 0x0) axi: Core 1 found: IEEE 802.11 (manuf 0x4BF, id 0x812, rev 0x17, class 0x0) axi: Core 2 found: PCIe (manuf 0x4BF, id 0x820, rev 0x0F, class 0x0) BCM4313 axi: Core 0 found: ChipCommon (manuf 0x4BF, id 0x800, rev 0x24, class 0x0) axi: Core 1 found: IEEE 802.11 (manuf 0x4BF, id 0x812, rev 0x18, class 0x0) axi: Core 2 found: PCIe (manuf 0x4BF, id 0x820, rev 0x11, class 0x0) -- Rafa?