From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Mon, 18 Apr 2011 14:19:38 +0200 Subject: Could I (ab)use bus (struct bus_type) for virtual Broadcom bus? In-Reply-To: <201104171938.12834.arnd@arndb.de> References: <1302892585.30441.12.camel@dev.znau.edu.ua> <201104171938.12834.arnd@arndb.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org W dniu 17 kwietnia 2011 19:38 u?ytkownik Arnd Bergmann napisa?: > On Friday 15 April 2011, Rafa? Mi?ecki wrote: >> W dniu 15 kwietnia 2011 20:36 u?ytkownik George Kashperko >> napisa?: >> >> >> Arnd: I found you saying: >> >> >> > I believe the one thing we really want from this driver is the bus >> >> >> > scan code, which is not present in the amba bus implementation, >> >> >> I explained how it works, I believe scanning (EPROM in this case) it >> >> >> Broadcom specific, not really AMBA standard. How do you see it? >> >> >> >> Maybe EPROM is not Broadcom specific, but I suspect the content we >> >> deal with in bcmai/axi is Broadcom specific. I didn't see any notes of >> >> manuf/id/rev/class we deal with. So I guess everything we (out >> >> driver) read from EPROM is Bcm specific. >> >> >> > >> > Played around amba registers on bcm4716. For all amba cores present >> > (under all I mean broadcom ip core agents, oob router core, erom core, >> > and other I-dont-know-what-for cores present at 0x18100000). All those >> > feature AMBA_CID (0xb105f00d) as PrimeCell ID, and slightly different >> > PrimeCell PeripheralIDs: >> > * vendor 0xBB, part_number 0x368 for broadcom cores' agents; >> > * vendor 0xBB, part_number 0x367 for OOB router core (don't ask me wth >> > is this please); >> > * vendor 0xBB, part_number 0x366 for EROM core; >> > >> > ARM vendor id is 0x41. Might 0xBB is Broadcom vendor id but I've found >> > no evidence for that with google. >> >> Yeah, as I suspected, everything except Broadcom specific cores >> matches AMBA standards quite nicely. Still, I don't see anything in it >> we could use for driver. >> >> Let's wait for Russell and Arnd to comment. > > In general, the bus_type directly relates to how a device gets probed. > If broadcom uses the same basic register layout as regular AMBA devices, > it should use the amba bus type.