From: "Rafał Miłecki" <zajec5@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: b43-dev <b43-dev@lists.infradead.org>,
linux-wireless@vger.kernel.org,
"Juan Carlos Romero" <juancarlos.romero@gmail.com>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Ben Greear" <greearb@candelatech.com>,
"Jamie Lokier" <jamie@shareable.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Alexander Shishkin" <virtuoso@slind.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: [hrtimers] Re: Regression affecting b43 LP-PHY card
Date: Tue, 10 May 2011 23:48:53 +0200 [thread overview]
Message-ID: <BANLkTinjcVjb-1wZahonmP5tjxOzQfMeFw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinnVwQbz+K32pyzLVCdz-fXUVUQ3g@mail.gmail.com>
2011/5/10 Rafa? Mi?ecki <zajec5@gmail.com>:
> 2011/5/10 John Stultz <john.stultz@linaro.org>:
>> On Tue, 2011-05-10 at 20:57 +0200, Rafa? Mi?ecki wrote:
>>> W dniu 10 maja 2011 00:52 u?ytkownik Rafa? Mi?ecki <zajec5@gmail.com> napisa?:
>>> > In this situation we decided to bisect. I was a little afraid of last
>>> > merges so we took older 2.6.38 as GOOD (we tested this twice) and
>>> > wireless-testing commit before my ssb changes as BAD. Today Juan
>>> > finished bisecting kernel:
>>> > http://pastebin.com/HSKbRzpB
>>> >
>>> > According to his bisection the first bad commit is
>>> > e06383db9ec591696a06654257474b85bac1f8cb [0]:
>>> > hrtimers: extend hrtimer base code to handle more then 2 clockids
>>> >
>>> > Does it make any sense to you? Could this be some timing issue?
>>> >
>>> > It was too late to test this today, we (Juan) will work on this
>>> > tomorrow. It's impossible to revert this commit from HEAD of
>>> > wireless-testing, so my idea is to checkout commit, test, revert,
>>> > test.
>>> >
>>> > Did anyone else experience any similar problems with latest wireless-testing?
>>> >
>>> >
>>> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e06383db9ec591696a06654257474b85bac1f8cb
>>>
>>> Today Juan checkouted commit e06383db9ec591696a06654257474b85bac1f8cb
>>> and tested it. He was disconnected really soon.
>>>
>>> Then he reverted e06383db9ec591696a06654257474b85bac1f8cb and tested
>>> again. Connection was stable, he downloaded 2GB file over network.
>>>
>>>
>>> John S.: your commit does not touch Broadcom card directly, but it
>>> seems it somehow affects it. I suspect there can be some timing issue.
>>> Do you have any idea what could it be, how can we debug this?
>>
>> Sorry for the trouble!
>>
>> My commit exposed a few spots where hrtimers were being initialized
>> before hrtimer_init is called, which caused problems. Thomas provided a
>> solution that makes such behavior still function ok:
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce31332d3c77532d6ea97ddcb475a2b02dd358b4
>>
>> Let me know if the issue is still reproducible with Linus' latest git
>> tree.
>
> We were using wireless-testing git tree, commit:
> 1e664a777e5eb4b23e65e76fbeadd2376fe8d8d8
>
> I can not see ce31332d3c77532d6ea97ddcb475a2b02dd358b4 it git log.
> I'll apply and test, thanks!
I can confirm updated wireless-testing resolves this issue!
Too bad Juan spent 2-3 days on bisecting on his Atom... but at least
we came and met ready fix. It could be pain to find a solution with
out feedback only. I'm aware it was not very detailed.
Thanks for your help :)
--
Rafa?
prev parent reply other threads:[~2011-05-10 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 22:52 Regression affecting b43 LP-PHY card Rafał Miłecki
2011-05-09 22:58 ` Ben Greear
2011-05-10 18:31 ` Larry Finger
2011-05-10 18:57 ` [hrtimers] " Rafał Miłecki
[not found] ` <1305054401.2939.52.camel@work-vm>
2011-05-10 19:45 ` Rafał Miłecki
2011-05-10 21:48 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinjcVjb-1wZahonmP5tjxOzQfMeFw@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arve@android.com \
--cc=b43-dev@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=jamie@shareable.org \
--cc=john.stultz@linaro.org \
--cc=juancarlos.romero@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=virtuoso@slind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).