From: "Rafał Miłecki" <zajec5@gmail.com>
To: b43-dev@lists.infradead.org
Subject: [PATCH] Fix alignment issues with DMA TX on BCM4331
Date: Sun, 14 Aug 2011 10:14:57 +0200 [thread overview]
Message-ID: <CACna6ryD6MGAjt5_fwqZKD=04-1ORs_zbRktuhDFV2cT+aeGvQ@mail.gmail.com> (raw)
In-Reply-To: <1313309045.28740.0.camel@i7.infradead.org>
W dniu 14 sierpnia 2011 10:04 u?ytkownik David Woodhouse
<dwmw2@infradead.org> napisa?:
> On Sun, 2011-08-14 at 09:35 +0200, Rafa? Mi?ecki wrote:
>>
>> > The brcm80211 driver doesn't; it writes TXCTL last, unconditionally.
>>
>> Uh, you mead me read that code... OK:
>>
>> if (!di->aligndesc_4k)
>> ? ? ? ? _dma_ddtable_init(di, DMA_TX, di->txdpa);
>>
>> if ((di->dma.dmactrlflags & DMA_CTRL_PEN) == 0)
>> ? ? ? ? control |= D64_XC_PD;
>> OR_REG(&di->d64txregs->control, control);
>>
>> if (di->aligndesc_4k)
>> ? ? ? ? _dma_ddtable_init(di, DMA_TX, di->txdpa);
>
> Hm, so I lied. Sorry about that. Will send a new patch.
>
> I'll also have another look at the RX path. I had tried enabling RX
> after setting the addresses, but that had failed.
Dump from ndis on BCM4331 for RX ring:
write32 0xb0600228 <- 0x1f85e000 ADDR_LO
write32 0xb060022c <- 0x80000000 ADDR_HI
read32 0xb0600220 -> 0x00000040 CTL (Frame Offset: 0x20)
write32 0xb0600220 <- 0x0000084d CTL (Frame Offset: 0x26 | Parity Disable)
write32 0xb0600224 <- 0x1f85e200 DESC_STOP
--
Rafa?
next prev parent reply other threads:[~2011-08-14 8:14 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:14 No DMA RX on some BCM4321, on BCM43224 and BCM43225 Rafał Miłecki
2011-07-18 20:29 ` Larry Finger
2011-07-18 22:30 ` Rafał Miłecki
2011-07-18 23:32 ` Rafał Miłecki
2011-07-19 6:56 ` Rafał Miłecki
2011-07-19 14:46 ` Larry Finger
2011-07-19 15:12 ` Jonas Gorski
2011-07-18 20:41 ` Michael Büsch
2011-07-18 22:39 ` Rafał Miłecki
2011-07-18 22:59 ` Michael Büsch
2011-07-18 23:07 ` Rafał Miłecki
2011-07-18 23:08 ` Michael Büsch
2011-07-18 23:15 ` Rafał Miłecki
2011-07-18 23:24 ` Michael Büsch
2011-07-18 23:29 ` Rafał Miłecki
2011-07-18 23:12 ` Rafał Miłecki
2011-07-19 22:33 ` David Woodhouse
2011-08-12 1:41 ` David Woodhouse
2011-08-12 10:15 ` [PATCH] b43: Mask out unwanted bits of RX slot address David Woodhouse
2011-08-13 19:10 ` Rafał Miłecki
2011-08-13 19:38 ` Michael Büsch
2011-08-13 22:13 ` Rafał Miłecki
2011-08-13 22:56 ` David Woodhouse
2011-08-14 8:18 ` Rafał Miłecki
2011-08-14 8:19 ` David Woodhouse
2011-08-14 9:02 ` Rafał Miłecki
2011-08-14 9:07 ` Rafał Miłecki
2011-08-14 9:24 ` Rafał Miłecki
2011-08-14 9:31 ` Rafał Miłecki
2011-08-14 11:17 ` Rafał Miłecki
2011-08-14 11:22 ` Rafał Miłecki
2011-08-14 11:35 ` David Woodhouse
2011-08-14 15:02 ` Rafał Miłecki
2011-08-14 15:10 ` Michael Büsch
2011-08-14 11:38 ` Rafał Miłecki
2011-08-14 11:52 ` Michael Büsch
2011-08-14 12:06 ` David Woodhouse
2011-08-14 13:43 ` Rafał Miłecki
2011-08-12 10:27 ` [PATCH] Fix alignment issues with DMA TX on BCM4331 David Woodhouse
2011-08-13 19:06 ` Rafał Miłecki
2011-08-13 20:18 ` David Woodhouse
2011-08-13 20:22 ` Rafał Miłecki
2011-08-13 20:36 ` David Woodhouse
2011-08-14 8:09 ` Rafał Miłecki
2011-08-13 21:57 ` Larry Finger
2011-08-13 22:02 ` Rafał Miłecki
2011-08-13 22:07 ` David Woodhouse
2011-08-13 22:12 ` Rafał Miłecki
2011-08-13 22:17 ` David Woodhouse
2011-08-14 7:10 ` Rafał Miłecki
2011-08-14 7:35 ` Rafał Miłecki
2011-08-14 8:04 ` David Woodhouse
2011-08-14 8:14 ` Rafał Miłecki [this message]
2011-08-13 22:14 ` Larry Finger
2011-08-13 22:17 ` David Woodhouse
2011-08-13 22:29 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACna6ryD6MGAjt5_fwqZKD=04-1ORs_zbRktuhDFV2cT+aeGvQ@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).