b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: "Michael Büsch" <m@bues.ch>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev@lists.infradead.org
Subject: [PATCH 2/2] b43: implement BCMA bus ops
Date: Wed, 6 Jul 2011 17:52:40 +0200	[thread overview]
Message-ID: <CACna6ryHRNLNPrPam2dAWLysqtFLtE8bcu4A26A4xFj2ui2eNg@mail.gmail.com> (raw)
In-Reply-To: <20110706174046.0ae24b6d@maggie>

W dniu 6 lipca 2011 17:40 u?ytkownik Michael B?sch <m@bues.ch> napisa?:
> On Tue, ?5 Jul 2011 23:54:08 +0200
> Rafa? Mi?ecki <zajec5@gmail.com> wrote:
>
>>
>> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
>> ---
>> ?drivers/net/wireless/b43/bus.c ?| ?100 +++++++++++++++++++++++++++++++++++++++
>> ?drivers/net/wireless/b43/bus.h ?| ? ?3 +
>> ?drivers/net/wireless/b43/main.c | ? ?7 +++
>> ?3 files changed, 110 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/bus.c b/drivers/net/wireless/b43/bus.c
>> index 4200713..f56604f 100644
>> --- a/drivers/net/wireless/b43/bus.c
>> +++ b/drivers/net/wireless/b43/bus.c
>> @@ -23,6 +23,106 @@
>> ?#include "b43.h"
>> ?#include "bus.h"
>>
>> +/* BCMA */
>> +#ifdef CONFIG_B43_BCMA
>> +static inline int b43_bus_bcma_bus_may_powerdown(struct b43_bus_dev *dev)
>> +{
>> + ? ? return 0; /* bcma_bus_may_powerdown(dev->bdev->bus); */
>> +}
>
> Why is this inline?
> You can't inline and take a pointer of the function at the same time.
> (The compiler will workaround this by generating multiple versions of
> the function, of which at least one is not inline).
> So remove it, please. Same below...

I didn't know about any such a limitation.

Just for sure: did you really mean "pointer of the function"? Cause my
function is taking pointer of the struct, not pointer of function.

-- 
Rafa?

  reply	other threads:[~2011-07-06 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 21:54 [PATCH 1/2] b43: make b43_wireless_init bus generic Rafał Miłecki
2011-07-05 21:54 ` [PATCH 2/2] b43: implement BCMA bus ops Rafał Miłecki
2011-07-06 15:40   ` Michael Büsch
2011-07-06 15:52     ` Rafał Miłecki [this message]
2011-07-06 15:58       ` Michael Büsch
2011-07-06 16:02         ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACna6ryHRNLNPrPam2dAWLysqtFLtE8bcu4A26A4xFj2ui2eNg@mail.gmail.com \
    --to=zajec5@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=m@bues.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).