b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: b43-dev@lists.infradead.org
Subject: [PATCH] b43: Mask out unwanted bits of RX slot address
Date: Sun, 14 Aug 2011 13:17:49 +0200	[thread overview]
Message-ID: <CACna6rzim3t-k5AcRmcyaaU=OcAkiTsL0arAd6ffSSy4VBHJ0Q@mail.gmail.com> (raw)
In-Reply-To: <CACna6ryZMW4+H7nT2Sf8FThYNngC6jgsURR0+N-jm2NZyiqikg@mail.gmail.com>

W dniu 14 sierpnia 2011 11:24 u?ytkownik Rafa? Mi?ecki
<zajec5@gmail.com> napisa?:
> W dniu 14 sierpnia 2011 11:07 u?ytkownik Rafa? Mi?ecki
> <zajec5@gmail.com> napisa?:
>> I guess we should just increase RX ring size instead hacking
>> (stripping) 0x1000 bit. We just need to check ?on which hardware wl
>> uses 256 ring size.
>
> Ignore that. I just got 8 KiB aligned ring when testing 256 ring size.
>
> I agree with David, that 0x1000 comes from ring address. Depending on
> address alignment it's 0 or 1.

I wanted to check if firmware ever uses 0x1000 for addressing
purposes. To test that I've increased RX ring size to 257 and waited
for 8 KiB aligned ring address (to avoid copying 0x1000 bit from
address).

[ 3963.448699] RX ring at 24661e000
(...)
[ 4041.766608] Read RXSTATUS 0x10000fc0 (makes offs 0xfc0, divided by
0x10 gives slot 0xfc
[ 4042.066683] Read RXSTATUS 0x10000fd0 (makes offs 0xfd0, divided by
0x10 gives slot 0xfd
[ 4042.070585] Read RXSTATUS 0x10000fe0 (makes offs 0xfe0, divided by
0x10 gives slot 0xfe
[ 4042.141030] Read RXSTATUS 0x10000ff0 (makes offs 0xff0, divided by
0x10 gives slot 0xff
[ 4042.206599] b43-phy0 ERROR: Fatal DMA error: 0x00011000,
0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000
[ 4042.208438] b43-phy0 ERROR: This device does not support DMA on
your system. It will now be switched to PIO.
[ 4042.210463] b43-phy0: Controller RESET (DMA error) ...

Maybe we should just change:
#define		B43_DMA64_TXSTATDPTR		0x00001FFF

-- 
Rafa?

  parent reply	other threads:[~2011-08-14 11:17 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18 20:14 No DMA RX on some BCM4321, on BCM43224 and BCM43225 Rafał Miłecki
2011-07-18 20:29 ` Larry Finger
2011-07-18 22:30   ` Rafał Miłecki
2011-07-18 23:32   ` Rafał Miłecki
2011-07-19  6:56     ` Rafał Miłecki
2011-07-19 14:46       ` Larry Finger
2011-07-19 15:12         ` Jonas Gorski
2011-07-18 20:41 ` Michael Büsch
2011-07-18 22:39   ` Rafał Miłecki
2011-07-18 22:59     ` Michael Büsch
2011-07-18 23:07       ` Rafał Miłecki
2011-07-18 23:08         ` Michael Büsch
2011-07-18 23:15           ` Rafał Miłecki
2011-07-18 23:24             ` Michael Büsch
2011-07-18 23:29               ` Rafał Miłecki
2011-07-18 23:12     ` Rafał Miłecki
2011-07-19 22:33 ` David Woodhouse
2011-08-12  1:41   ` David Woodhouse
2011-08-12 10:15     ` [PATCH] b43: Mask out unwanted bits of RX slot address David Woodhouse
2011-08-13 19:10       ` Rafał Miłecki
2011-08-13 19:38         ` Michael Büsch
2011-08-13 22:13       ` Rafał Miłecki
2011-08-13 22:56         ` David Woodhouse
2011-08-14  8:18           ` Rafał Miłecki
2011-08-14  8:19             ` David Woodhouse
2011-08-14  9:02         ` Rafał Miłecki
2011-08-14  9:07           ` Rafał Miłecki
2011-08-14  9:24             ` Rafał Miłecki
2011-08-14  9:31               ` Rafał Miłecki
2011-08-14 11:17               ` Rafał Miłecki [this message]
2011-08-14 11:22                 ` Rafał Miłecki
2011-08-14 11:35                 ` David Woodhouse
2011-08-14 15:02                   ` Rafał Miłecki
2011-08-14 15:10                     ` Michael Büsch
2011-08-14 11:38                 ` Rafał Miłecki
2011-08-14 11:52                   ` Michael Büsch
2011-08-14 12:06                   ` David Woodhouse
2011-08-14 13:43                     ` Rafał Miłecki
2011-08-12 10:27     ` [PATCH] Fix alignment issues with DMA TX on BCM4331 David Woodhouse
2011-08-13 19:06       ` Rafał Miłecki
2011-08-13 20:18         ` David Woodhouse
2011-08-13 20:22           ` Rafał Miłecki
2011-08-13 20:36             ` David Woodhouse
2011-08-14  8:09           ` Rafał Miłecki
2011-08-13 21:57       ` Larry Finger
2011-08-13 22:02         ` Rafał Miłecki
2011-08-13 22:07           ` David Woodhouse
2011-08-13 22:12             ` Rafał Miłecki
2011-08-13 22:17               ` David Woodhouse
2011-08-14  7:10                 ` Rafał Miłecki
2011-08-14  7:35                 ` Rafał Miłecki
2011-08-14  8:04                   ` David Woodhouse
2011-08-14  8:14                     ` Rafał Miłecki
2011-08-13 22:14           ` Larry Finger
2011-08-13 22:17             ` David Woodhouse
2011-08-13 22:29               ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACna6rzim3t-k5AcRmcyaaU=OcAkiTsL0arAd6ffSSy4VBHJ0Q@mail.gmail.com' \
    --to=zajec5@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).