From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: "backports@vger.kernel.org" <backports@vger.kernel.org>
Subject: Re: [PATCH 6/9] lib/bpgit.py: add support for git paranoia
Date: Tue, 28 May 2013 22:17:31 +0200 [thread overview]
Message-ID: <1369772251.8548.25.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB=NE6VY=BAxfs9MCXxc8=fabt0bBbmcTwr7rovRG42ZUvEATA@mail.gmail.com> (sfid-20130528_220232_801968_6B5C331B)
On Tue, 2013-05-28 at 13:02 -0700, Luis R. Rodriguez wrote:
> On Thu, May 23, 2013 at 2:02 PM, Luis R. Rodriguez
> <mcgrof@do-not-panic.com> wrote:
> > I see what you're saying now and I actually did consider it, the
> > reason I didn't use --git-revision is speed. Git reset --hard tag, and
> > then copying the code directly is a lot faster. The race issues you
> > point out though are worth reconsidering this though.
>
> I've given this some thought and I find that the theoretical race
> conditions also applies even if you use --git-revision on the output
> path.
Well, to be honest, you have to trust the system anyway, otherwise it
can mess up completely. So I guess the race is pretty much unimportant.
It was just an additional thing to consider, more in case you start this
as a long-running process and then (accidentally) work with the
linux-next tree in another way.
However I'd argue that since the git object database would typically be
corrupted by changes impacting --git-revision usage, it's still a lot
safer than using checkouts.
> A true paranoid release model would then have a target output
> directory only the parent process and children could modify / update
> but given it seems we have considerations for non ext[34] filesystems
> (recent kconfig patch) its unclear we could resolve this for the truly
> paranoid. The speed considerations I raised then (10 seconds as of
> next-20130523 with python-git installed) could be discarded in favor
> of consistency of just using --git-revision for a release model
> provided we also address the RELMOD_UPDATE and RELMOD_TYPE
> specification for both daily and stable releases, defined on the
> upload_release() documentation. Right now we infer RELMOD_UPDATE based
> on the output directory but inferring RELMOD_TYPE from the same target
> output directory would be sloppy IMO so tackling these two with
> --git-revision would need to be addressed.
Well like I said before, I think you should probably just write a
separate script (possibly as a devel/ script) that you'd do something
like
./devel/gen-and-kup.py /path/to/linux-next/ next-20130528
and then it would internally create a temporary directory (with tempdir
thing) and run something like
./gentree.py --git-revision next-20130528 /path/to/linux-next/ /tmp/tmpdir/<relname>/
(obviously not calling the script but rather the function like
git-tracker does)
and then work in /tmp/tmpdir/ to create the tarball etc. That way, you
don't have temporary stuff lying around after the generation, and get
rid of many of the changes you're making here since you wouldn't need
the paranoia stuff.
johannes
next prev parent reply other threads:[~2013-05-28 20:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 11:34 [PATCH 0/9] backports: add kernel uploading support Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 1/9] lib/bpgit.py: make git describe --long optional Luis R. Rodriguez
2013-05-22 12:02 ` Johannes Berg
2013-05-22 21:49 ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 2/9] lib/bpgit.py: add git describe --dirty support Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 3/9] lib/bpgit.py: add git status support Luis R. Rodriguez
2013-05-22 12:02 ` Johannes Berg
2013-05-23 0:28 ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 4/9] lib/bpgit.py: add git clean support Luis R. Rodriguez
2013-05-22 12:03 ` Johannes Berg
2013-05-23 0:28 ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 5/9] lib/bpgit.py: add git tree verification support Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 6/9] lib/bpgit.py: add support for git paranoia Luis R. Rodriguez
2013-05-22 12:05 ` Johannes Berg
2013-05-23 0:37 ` Luis R. Rodriguez
2013-05-23 15:25 ` Johannes Berg
2013-05-23 21:02 ` Luis R. Rodriguez
2013-05-28 20:02 ` Luis R. Rodriguez
2013-05-28 20:14 ` Luis R. Rodriguez
2013-05-28 20:23 ` Johannes Berg
2013-07-27 17:11 ` Luis R. Rodriguez
2013-05-28 20:17 ` Johannes Berg [this message]
2013-05-22 11:34 ` [PATCH 7/9] lib/bpgpg.py: add simple gpg helpers for --armor --detach-sign Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 8/9] lib/bpkup.py: add or own kernel uploader helper lib Luis R. Rodriguez
2013-05-22 12:06 ` Johannes Berg
2013-05-23 0:43 ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 9/9] gentree.py: add kernel upload support Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369772251.8548.25.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox