From: "Arend van Spriel" <arend@broadcom.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: backports@vger.kernel.org, "Arend van Spriel" <arend@broadcom.com>
Subject: [PATCH] compat-drivers: do not disable bcma when selecting brcmsmac
Date: Sun, 9 Jun 2013 21:37:39 +0200 [thread overview]
Message-ID: <1370806659-2875-1-git-send-email-arend@broadcom.com> (raw)
The brcmsmac driver depends on the bcma bus driver these days. However,
the driver-select script disabled bcma when selecting brcmsmac (or
the brcm80211 driver group). This leads to mismatch between kernel
bcma and backport brcmsmac. For the 3.9 backport this result in:
[10298.323094] brcmsmac: Unknown symbol bcma_pmu_spuravoid_pllupdate (err 0)
as this function was added to bcma.
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
scripts/driver-select | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/scripts/driver-select b/scripts/driver-select
index 862f43b..c6afdfc 100755
--- a/scripts/driver-select
+++ b/scripts/driver-select
@@ -408,7 +408,10 @@ case $1 in
;;
brcm80211)
disable_staging
- disable_bt_usb_ethernet_var
+ disable_bt_usb_ethernet
+ disable_ssb
+ disable_eeprom
+ disable_lib80211
select_drivers CONFIG_BRCMUTIL \
CONFIG_BRCMFMAC \
CONFIG_BRCMSMAC
@@ -465,13 +468,17 @@ case $1 in
;;
brcmsmac)
disable_staging
- disable_bt_usb_ethernet_var
+ disable_bt_usb_ethernet
+ disable_ssb
+ disable_eeprom
+ disable_lib80211
select_drivers CONFIG_BRCMSMAC
select_brcm80211_driver CONFIG_BRCMSMAC CONFIG_BRCMUTIL
;;
brcmfmac)
disable_staging
disable_bt_usb_ethernet_var
+ disable_lib80211
select_drivers CONFIG_BRCMFMAC
select_brcm80211_driver CONFIG_BRCMFMAC CONFIG_BRCMUTIL
;;
--
1.7.10.4
next reply other threads:[~2013-06-09 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 19:37 Arend van Spriel [this message]
2013-06-13 19:39 ` [PATCH] compat-drivers: do not disable bcma when selecting brcmsmac Luis R. Rodriguez
2013-06-13 20:00 ` Arend van Spriel
2013-06-13 20:05 ` Arend van Spriel
2013-06-13 20:09 ` Johannes Berg
2013-06-13 20:34 ` Arend van Spriel
2013-06-13 20:47 ` Luis R. Rodriguez
2013-06-14 8:00 ` Arend van Spriel
2013-06-13 21:07 ` Hauke Mehrtens
2013-06-13 20:06 ` Luis R. Rodriguez
2013-06-13 20:13 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370806659-2875-1-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox