From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: backports@vger.kernel.org, linux-kernel@vger.kernel.org,
yann.morin.1998@free.fr, mmarek@suse.cz, sassmann@kpanic.de,
"Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [RFC v2 1/4] backports: replace CPTCFG prefix for CONFIG_BACKPORT
Date: Fri, 31 Oct 2014 08:41:13 +0100 [thread overview]
Message-ID: <1414741273.3014.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1414570902-5675-2-git-send-email-mcgrof@do-not-panic.com> (sfid-20141029_092323_908667_855CE841)
On Wed, 2014-10-29 at 01:21 -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> In order to support built-in kernel integration we want to use
> a more generic approach to defining symbols, CPTCFG was nice as
> it was short and relied on the fact that kconfig can work with
> a getenv(CONFIG_) but for kernel integration this doesn't work
> so well. Instead let's just stick to the regular CONFIG_
> namespace and add the BACKPORT prefix to it.
>
> Apart from these expected changes:
>
> for i in $(find ./ | grep -v "\.git"); do perl -pi -e'$_ =~ s|CPTCFG|CONFIG_BACKPORT|gs;' $i; done
I really think you need to make this optional for the in-tree
generation, otherwise it will complicate things a lot for anyone who's
already using backports in a way that doesn't have it regenerated all
the time.
Additionally, CPTCFG_ had the advantage of having the same length as
CONFIG_, so code style wise it was nicer to replace.
Please make this a post-process step that runs on everything, including
the backport stuff, rather than running only on the source and assuming
the backport stuff already uses this convention.
johannes
next prev parent reply other threads:[~2014-10-31 7:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 8:21 [RFC v2 0/4] backports: kernel integration support Luis R. Rodriguez
2014-10-29 8:21 ` [RFC v2 1/4] backports: replace CPTCFG prefix for CONFIG_BACKPORT Luis R. Rodriguez
2014-10-31 7:41 ` Johannes Berg [this message]
2014-10-31 19:34 ` Luis R. Rodriguez
2014-10-31 20:22 ` Johannes Berg
2014-10-31 20:33 ` Luis R. Rodriguez
2014-11-03 19:30 ` Luis R. Rodriguez
2014-11-03 19:40 ` Johannes Berg
2014-11-03 19:56 ` Luis R. Rodriguez
2014-11-03 20:20 ` Johannes Berg
2014-11-03 20:21 ` Luis R. Rodriguez
2014-11-03 20:24 ` Johannes Berg
2014-11-03 20:26 ` Luis R. Rodriguez
2014-10-29 8:21 ` [RFC v2 2/4] backports: replace BACKPORT_PWD with BACKPORT_DIR Luis R. Rodriguez
2014-10-31 7:41 ` Johannes Berg
2014-10-31 19:35 ` Luis R. Rodriguez
2014-10-29 8:21 ` [RFC v2 3/4] backports: use BACKPORT_DIR prefix on kconfig sources Luis R. Rodriguez
2014-10-31 7:46 ` Johannes Berg
2014-10-31 20:03 ` Luis R. Rodriguez
2014-10-29 8:21 ` [RFC v2 4/4] backports: add kernl integration support to gentree.py Luis R. Rodriguez
2014-10-29 15:36 ` Stefan Assmann
2014-10-29 16:00 ` Luis R. Rodriguez
2014-10-31 7:50 ` Johannes Berg
2014-10-31 20:10 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414741273.3014.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mmarek@suse.cz \
--cc=sassmann@kpanic.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox