From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:50976 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502AbdBGG3N (ORCPT ); Tue, 7 Feb 2017 01:29:13 -0500 Message-ID: <1486448949.5430.10.camel@sipsolutions.net> (sfid-20170207_072915_658212_7ABB2388) Subject: Re: [PATCH 3/3] backports: support class_groups From: Johannes Berg To: Arend Van Spriel , backports@vger.kernel.org Date: Tue, 07 Feb 2017 07:29:09 +0100 In-Reply-To: <445404f1-7231-fb2f-0faf-5093b69926ae@broadcom.com> (sfid-20170206_233705_198112_9B6CF8A7) References: <20170206123956.20082-1-johannes@sipsolutions.net> <20170206123956.20082-3-johannes@sipsolutions.net> <445404f1-7231-fb2f-0faf-5093b69926ae@broadcom.com> (sfid-20170206_233705_198112_9B6CF8A7) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: backports-owner@vger.kernel.org List-ID: > > Change-Id: I114e1a6ed8db901b3aa738a5052721d1da45cae4 > > Does it make sense to keep the Change-Id: things here? Not really. But eventually I got lazy. I've now removed the auto- generation for my tree, which means I'll have to add it manually internally, but whatever :) > > +@ class_group @ > > +identifier group_class; > > +identifier attribute_groups_name.groups; > > +fresh identifier group_dev_attr = attribute_group.group ## > > "_dev_attrs"; > > So how will this work wrt naming scheme. Can we be sure all > class_attrs occurrences in the files we copy are named as such, ie. > with _dev_attrs post-fix? No no, that's not what happens here. The _dev_attrs postfix is generated by the ATTRIBUTE_GROUPS_BACKPORT() macro. johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in