From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:41704 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdFLJLN (ORCPT ); Mon, 12 Jun 2017 05:11:13 -0400 Message-ID: <1497258670.18110.1.camel@sipsolutions.net> (sfid-20170612_111114_863595_3E36F253) Subject: Re: [PATCH] backport: handle change in netdevice destructor usage From: Johannes Berg To: Arend van Spriel Cc: backports@vger.kernel.org Date: Mon, 12 Jun 2017 11:11:10 +0200 In-Reply-To: <1497258385-5116-1-git-send-email-arend.vanspriel@broadcom.com> (sfid-20170612_110637_487182_292F64A6) References: <1497258385-5116-1-git-send-email-arend.vanspriel@broadcom.com> (sfid-20170612_110637_487182_292F64A6) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: backports-owner@vger.kernel.org List-ID: On Mon, 2017-06-12 at 10:06 +0100, Arend van Spriel wrote: > This patch deals with changes made in struct net_device by commit > cf124db566e6 ("net: Fix inconsistent teardown and release of private > netdev state."). This only looks for instances that need > free_netdev() call, ie. struct net_device::needs_free_netdev == true. I think we may need to worry about more kernel versions than just 4.12 here, since this stuff is getting backported, and then it would cause double-frees. I'm also considering simply removing the priv_destructor entirely from mac80211, but I guess this would still apply to other drivers. johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in