Re: [PATCH] header: fix compile error on PowerPC (PPC_85xx)

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2017-10-02 at 20:31 +0200, Hauke Mehrtens wrote:
> On 10/02/2017 02:39 PM, Johannes Berg wrote:
> > On Sun, 2017-10-01 at 21:38 +0200, Hauke Mehrtens wrote:
> > > Including linux/interrupt.h in linux/hrtimer.h causes this error
> > > message
> > > on PowerPC builds on x86, ARM and MIPS it works:
> > 
> > I think I also saw this on x86 on older kernel versions, and
> > couldn't
> > really figure out what was causing it...
> 
> I haven't fully understood this issue, but the LEDE build bot found
> it
> on multiple PowerPC based systems. With this patch applied it is
> compiling on all targets.
> 
> I ran the build test script on the compat server and it was fine with
> this patch applied for all kernel versions that worked before.

Ok.

> > > The backport of the hrtimer_start() functions needs the
> > > linux/interrupt.h because some parts are defined there. Fix this
> > > by
> > > moving the hrtimer_start() backport to the linux/interrupt.h
> > > backport
> > > header file.
> > 
> > Does hrtimre.h always include interrupt.h, so that we get it in
> > when
> > somebody includes just hrtimer.h?
> 
> I do not know, it is not included directly.

I guess we'll find out :-)

I'll apply this.

thanks,
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in