Linux backports project
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: 吳重毅 <uranus0206@gmail.com>
Cc: backports@vger.kernel.org
Subject: Re: Compiling error of backport-4.12.c
Date: Mon, 30 Oct 2017 21:03:59 +0100	[thread overview]
Message-ID: <1509393839.2637.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1509005208.2421.51.camel@sipsolutions.net> (sfid-20171026_100654_665631_5F5B08F1)

On Thu, 2017-10-26 at 10:06 +0200, Johannes Berg wrote:
> On Thu, 2017-10-26 at 09:29 +0200, Johannes Berg wrote:
> > On Thu, 2017-10-26 at 11:52 +0800, 吳重毅 wrote:
> > > Thankd for fixing, i am able compile now.
> > 
> > Ok, great.
> > 
> > > But when i load the modules and firmware.bin, it crash.
> > 
> > Crap, sorry about that. I'll see what I can do about it right now.
> 
> Ok, I see the bug. Not sure yet how to fix, but yeah.

I thought I said I'd fixed it, but don't see that email.

Anyway, I did, but Luca found another bug ... where it compiles, this
fixes it, I think:

--- a/compat/backport-4.12.c
+++ b/compat/backport-4.12.c
@@ -225,6 +225,7 @@ int bp_extack_genl_register_family(struct genl_family *family)
 
 	/* copy this since the family might access it directly */
 	family->attrbuf = copy->family.attrbuf;
+	family->mcgrp_offset = copy->family.mcgrp_offset;
 
 	mutex_lock(&copies_mutex);
 	list_add_tail(&copy->list, &copies_list);

But on older kernels this doesn't compile, and needs more work.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

  reply	other threads:[~2017-10-30 20:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 10:37 Compiling error of backport-4.12.c 吳重毅
2017-10-24 11:12 ` Johannes Berg
2017-10-24 14:09   ` Johannes Berg
2017-10-26  3:52     ` 吳重毅
2017-10-26  7:29       ` Johannes Berg
2017-10-26  8:06         ` Johannes Berg
2017-10-30 20:03           ` Johannes Berg [this message]
2017-10-31 11:58             ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509393839.2637.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=backports@vger.kernel.org \
    --cc=uranus0206@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox