Linux backports project
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Michael McElroy <mikem388@gmail.com>, backports@vger.kernel.org
Subject: Re: Errors backporting to 3.4
Date: Wed, 06 Dec 2017 22:18:33 +0100	[thread overview]
Message-ID: <1512595113.26976.36.camel@sipsolutions.net> (raw)
In-Reply-To: <CAJt7DwwqoJMWk1=-BO5O+cfutLfTwE04oYo46GqcMhb9zgGwPA@mail.gmail.com> (sfid-20171205_172916_304793_B93BEC9D)

Hi,

So, frankly, we haven't been maintaining < 3.10 or so well.

> I tried building against various kernels and didn't find
> netdev_upper_dev_link' defined until 3, so anything less that that probably
> has this error.  I didn't know exactly what to use here so I just did an
> #if 0 around that section and resolved the problem for me.

IIRC we did the same in our internal tree, it simply can't be done on
earlier kernels - Luca, care to send that out?

> The second problem is in commit 2ebca7b7d087be04e25b1fc50cf08137d423af3d.
> 
> Author: Luca Coelho <luciano.coelho@intel.com>
> Date:   Tue Apr 19 22:13:11 2016 +0300
> 
>     backport: add pm_runtime_active() implementation for < 3.9 kernels

Oi, that's pretty old.

> In linux/pm.h, those members addition to the struct are controlled by
> CONFIG_PM_RUNTIME, not CONFIG_PM. I changed pm_runtime.h to
> use CONFIG_PM_RUNTIME and that resolved the problem.

Interesting. Can you send the patch?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

      reply	other threads:[~2017-12-06 21:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 16:29 Errors backporting to 3.4 Michael McElroy
2017-12-06 21:18 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512595113.26976.36.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=backports@vger.kernel.org \
    --cc=mikem388@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox