From: Arend van Spriel <arend@broadcom.com>
To: Hauke Mehrtens <hauke@hauke-m.de>,
Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, <backports@vger.kernel.org>
Subject: Re: [PATCH] backports: random: add prandom_bytes macro for pre-3.8 kernels
Date: Sun, 22 Dec 2013 18:27:02 +0100 [thread overview]
Message-ID: <52B720E6.3070809@broadcom.com> (raw)
In-Reply-To: <52B71E44.7040600@hauke-m.de>
On 12/22/2013 06:15 PM, Hauke Mehrtens wrote:
> On 12/22/2013 01:28 PM, Johannes Berg wrote:
>> On Sun, 2013-12-22 at 12:57 +0100, Arend van Spriel wrote:
>>> Map prandom_bytes() calls to get_random_bytes() for kernels before
>>> 3.8 kernel. This patch is needed by mac80211 rate control code
>>> since following:
>>
>>> +/* use get_random_bytes() for lack of prandom_bytes() */
>>> +#define prandom_bytes(a, b) get_random_bytes(a, b)
>>
>> I don't think this is a good idea, it's a completely different interface
>> (get_random_bytes is much higher "quality".)
>>
>> We had a different patch for this fairly recently and I thought Luis
>> applied it?
>
> Yes a different patch is already in backports:
> https://git.kernel.org/cgit/linux/kernel/git/backports/backports.git/commit/?id=40ab1bac8c3680d726ee31fbdb590584ae99756f
I was looking at your github repo, because kernel.org did not work for
3.13 a while ago. Distributed version control can be a curse as well as
a blessing.
Gr. AvS
prev parent reply other threads:[~2013-12-22 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 11:57 [PATCH] backports: random: add prandom_bytes macro for pre-3.8 kernels Arend van Spriel
2013-12-22 12:28 ` Johannes Berg
2013-12-22 17:15 ` Hauke Mehrtens
2013-12-22 17:27 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B720E6.3070809@broadcom.com \
--to=arend@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox