Linux backports project
 help / color / mirror / Atom feed
From: Javier Casas Marin <jcasas@wifense.com>
To: backports@vger.kernel.org
Subject: Re: error compiling backports-3.14-1: too many arguments to function 'request_firmware_nowait'
Date: Mon, 08 Sep 2014 11:44:06 +0200	[thread overview]
Message-ID: <540D7A66.5060802@wifense.com> (raw)
In-Reply-To: <540D6A0A.30609@wifense.com>


Hi,
after a bit more investigation I  found this:

wsos-sdk:~/modules/backports-3.14-1# grep compat_firmware_class 
compat/Makefile
obj-$(CPTCFG_BACKPORT_BUILD_FW_LOADER) += compat_firmware_class.o

so I looked in compat/Kconfig and found this (I didn't find it before 
because I grep with the CPTCFG_ header):

config BACKPORT_BUILD_FW_LOADER
     tristate
     depends on m
     # RHEL6, starting from 6.0, backports the FW loader already
     depends on !BACKPORT_RHEL_KERNEL_6_0
     depends on !FW_LOADER || BACKPORT_KERNEL_2_6_33
     default m if BACKPORT_FW_LOADER
     default m if BACKPORT_USERSEL_BUILD_ALL

config BACKPORT_FW_LOADER
     bool

from here I understand that I have to enable de BACKPORT_FW_LOADER option.
I haven't found it in menuconfig so I changed it manually in 
compat/Kconfig to 'def_bool y'

Now the error went away but a new one appeared:

   CC [M]  /root/modules/backports-3.14-1/net/mac80211/key.o
/root/modules/backports-3.14-1/net/mac80211/key.c: In function 
'ieee80211_set_key_tx_seq':
/root/modules/backports-3.14-1/net/mac80211/key.c:813: error: implicit 
declaration of function 'atomic64_set'
make[6]: *** [/root/modules/backports-3.14-1/net/mac80211/key.o] Error 1
make[5]: *** [/root/modules/backports-3.14-1/net/mac80211] Error 2
make[4]: *** [_module_/root/modules/backports-3.14-1] Error 2
make[3]: *** [modules] Error 2
make[2]: *** [modules] Error 2
make[1]: *** [modules] Error 2
make: *** [default] Error 2

I'll try to figure out what happens this time

Javi

El 08/09/2014 10:34, Javier Casas Marin escribió:
>
> Hi,
> when I try to compile backports-3.14-1 in a 2.6.30 kernel I get this 
> error:
>
> /root/modules/backports-3.14-1/drivers/net/wireless/ath/ath9k/init.c: 
> In function 'ath9k_eeprom_request':
> /root/modules/backports-3.14-1/drivers/net/wireless/ath/ath9k/init.c:647: 
> warning: passing argument 5 of 'request_firmware_nowait' makes pointer 
> from integer without a cast
> /root/modules/backports-3.14-1/drivers/net/wireless/ath/ath9k/init.c:647: 
> warning: passing argument 6 of 'request_firmware_nowait' from 
> incompatible pointer type
> /root/modules/backports-3.14-1/drivers/net/wireless/ath/ath9k/init.c:647: 
> error: too many arguments to function 'request_firmware_nowait'
> make[8]: *** 
> [/root/modules/backports-3.14-1/drivers/net/wireless/ath/ath9k/init.o] 
> Error 1
> make[7]: *** 
> [/root/modules/backports-3.14-1/drivers/net/wireless/ath/ath9k] Error 2
> make[6]: *** [/root/modules/backports-3.14-1/drivers/net/wireless/ath] 
> Error 2
> make[5]: *** [/root/modules/backports-3.14-1/drivers/net/wireless] 
> Error 2
> make[4]: *** [_module_/root/modules/backports-3.14-1] Error 2
> make[3]: *** [modules] Error 2
> make[2]: *** [modules] Error 2
> make[1]: *** [modules] Error 2
> make: *** [default] Error 2
>
> I saw that in backport-include/linux/firmware.h there is a 
> pre-compiler directive to use the backport's version of 
> request_firmware_nowait function:
>
> #if defined(CPTCFG_BACKPORT_BUILD_FW_LOADER_MODULE)
> #define request_firmware_nowait LINUX_BACKPORT(request_firmware_nowait)
>
> But I haven't found where the CPTCFG_BACKPORT_BUILD_FW_LOADER_MODULE 
> is defined.
>
> I just ran:
> make defconfig-ath9k
> make
>
> Am I missing a previous configuration step?
>
> Thanks!
> -- 
> To unsubscribe from this list: send the line "unsubscribe backports" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2014-09-08  9:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08  8:34 error compiling backports-3.14-1: too many arguments to function 'request_firmware_nowait' Javier Casas Marin
2014-09-08  9:44 ` Javier Casas Marin [this message]
2014-09-08 10:30   ` Javier Casas Marin
2014-09-09  7:30     ` Javier Casas Marin
2014-09-09  7:38       ` Arend van Spriel
2014-09-09  7:36     ` Arend van Spriel
2014-09-09  7:47       ` Javier Casas Marin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540D7A66.5060802@wifense.com \
    --to=jcasas@wifense.com \
    --cc=backports@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox