From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.web.de ([212.227.17.11]:61422 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbaLCNZK (ORCPT ); Wed, 3 Dec 2014 08:25:10 -0500 Message-ID: <547F0F2A.3060708@users.sourceforge.net> (sfid-20141203_142536_538810_8C63D696) Date: Wed, 03 Dec 2014 14:24:58 +0100 From: SF Markus Elfring MIME-Version: 1.0 To: Dan Carpenter CC: Julia Lawall , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jonathan Corbet , OGAWA Hirofumi , Coccinelle , backports@vger.kernel.org, Johannes Berg , "Luis R. Rodriguez" Subject: Re: [patch] CodingStyle: add some more error handling guidelines References: <20141202085950.GA13434@mwanda> <547F0297.6030202@users.sourceforge.net> <20141203124511.GR5048@mwanda> <547F0977.7090908@users.sourceforge.net> <20141203132002.GT5048@mwanda> In-Reply-To: <20141203132002.GT5048@mwanda> Content-Type: text/plain; charset=windows-1252 Sender: backports-owner@vger.kernel.org List-ID: > Sorry. I misread your email. If the code looks like this: > > foo = kmalloc(); > if (!foo) > goto kmalloc_failed; > > The "kmalloc_failed" doesn't add any information. I find that this such a name approach would fit to your expectation of a source-oriented labeling of these identifiers. > We can see that kmalloc failed from the context. Which name pattern do you find more appropriate in such an use case? Regards, Markus