From: Arend van Spriel <arend@broadcom.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: "backports@vger.kernel.org" <backports@vger.kernel.org>
Subject: Re: backport fails for brcmfmac
Date: Mon, 13 Apr 2015 11:35:33 +0200 [thread overview]
Message-ID: <552B8DE5.7090206@broadcom.com> (raw)
In-Reply-To: <552ACDB0.2000607@hauke-m.de>
On 04/12/15 21:55, Hauke Mehrtens wrote:
> On 04/12/2015 07:18 PM, Arend van Spriel wrote:
>> I rebased our internel backports tree to backports/master and now I get
>> the following build error when backporting to 3.13 kernel:
>>
>> /tmp/brcm-backports-gb8d29dc/drivers/net/wireless/brcm80211/brcmfmac/p2p.c:2315:11:
>> error: ���struct net_device��� has no member named ���name_assign_type���
>> ifp->ndev->name_assign_type = name_assign_type;
>>
>> Obviously struct netdevice does not have name_assign_type in older
>> kernels, ie. kernels< 3.17 looking at
>> backport-include/linux/netdevice.h. Just not sure what made this issue
>> come up. The assignment was introduced by:
>>
>> commit 6bab2e19c5ffd1f21b28c2cabb3801a37b77ae69
>> Author: Tom Gundersen<teg@jklm.no>
>> Date: Wed Mar 18 11:13:39 2015 +0100
>>
>> cfg80211: pass name_assign_type to rdev_add_virtual_intf()
>>
>> Probably need to rework brcmfmac code to avoid the assignment and pass
>> the name_assign_type to the alloc_netdev call. If there is an easier way
>> feel free to let me know.
>
> I think this name_assign_type member is only used to show how the device
> name was assigned to the device. See name_assign_type in
> Documentation/ABI/testing/sysfs-class-net
> On kernel versions which do not support this sysfs entry, we can just
> ignore this new member. I think it is save to just add an "#if linux>=
> 3.17" around this assignment.
Well. I don't want to do that upstream so that would mean adding a patch
in backports that needs to be maintained which I prefer to avoid. I will
see whether I can rework the code.
Regards,
Arend
prev parent reply other threads:[~2015-04-13 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 17:18 backport fails for brcmfmac Arend van Spriel
2015-04-12 19:55 ` Hauke Mehrtens
2015-04-13 9:35 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552B8DE5.7090206@broadcom.com \
--to=arend@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=hauke@hauke-m.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox