From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Arend van Spriel <arend@broadcom.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: backports@vger.kernel.org
Subject: Re: [PATCH] backports: genetlink: add define for GENL_UNS_ADMIN_PERM
Date: Tue, 17 May 2016 11:03:48 +0200 [thread overview]
Message-ID: <573ADE74.3060107@broadcom.com> (raw)
In-Reply-To: <1463426878.2179.5.camel@sipsolutions.net>
On 16-5-2016 21:27, Johannes Berg wrote:
> On Sun, 2016-05-15 at 11:13 +0200, Arend van Spriel wrote:
>> Since commit 5ed071ec9992 ("nl80211: Allow privileged operations
>> from user namespaces") the definition GENL_UNS_ADMIN_PERM is used
>> by nl80211.c. Add definition if not defined by target kernel.
>
> NACK, this patch is really bad and breaks all security properties since
> older kernels will not know anything about the flag 0x10, they will
> assume that no permission checks are required.
Obviously been cutting to many corners here.
> The only sane thing to do is to
> #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
>
> and not get the user-namespace-awareness on kernels that didn't know
> about the flag already.
Will send a v2 using your suggestion.
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in
prev parent reply other threads:[~2016-05-17 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 9:13 [PATCH] backports: genetlink: add define for GENL_UNS_ADMIN_PERM Arend van Spriel
2016-05-16 19:27 ` Johannes Berg
2016-05-17 9:03 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573ADE74.3060107@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=arend@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox