Re: wireless_nlevent_flush backported to stable kernels

[Arend Van Spriel <arend.vanspriel@broadcom.com>]

On 16-5-2016 21:26, Johannes Berg wrote:
> On Sun, 2016-05-15 at 11:50 +0200, Arend Van Spriel wrote:
>>  
>>> On my system, I fixed it with the patch below, but it is surely not
>>> good enough.
>> In general this is avoided by preceeding the stub function with:
>>
>> #define wireless_nlevent_flush LINUX_BACKPORT(wireless_nlevent_flush)
>>
>> This way you will use the stub and not the in-kernel function.
> 
> That's normally fine, but not a good idea here because this really is a
> *stub*, and thus using the stub instead of the real function removes
> the ability to actually get the bugfix. So in this case, where it's a
> stub and not a full backport, it's better to try to get the original
> function in as many situations as possible.
> 
>> There has
>> been discussions about adding a mechanism to avoid backport if kernel
>> has the function available. No actual work in that area has been done
>> yet.
> 
> Oh, I've done that - but it was so terribly slow that it was
> essentially unusable...

I remember and so the suggestion was to maintain a list of functions to
check. Or did you pursue that as well with same result?

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in