From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>, backports@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] backports: add nla_put_u64_64bit()
Date: Tue, 31 May 2016 21:38:40 +0200 [thread overview]
Message-ID: <574DE840.4060009@broadcom.com> (raw)
In-Reply-To: <1464703661-10164-1-git-send-email-johannes@sipsolutions.net>
On 31-05-16 16:07, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Backport it simply using nla_put_u64(). This is fine for all the
> current users, but probably should be fixed.
I submitted a patch including this a couple of weeks ago titled:
"backports: netlink: add 64-bit aligned helper functions".
Regards,
Arend
> Change-Id: I0a48b90cdd081a7cba67ad592933ab266093c831
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> backport/backport-include/net/netlink.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/backport/backport-include/net/netlink.h b/backport/backport-include/net/netlink.h
> index 40160b57bc7a..570d440a9d2c 100644
> --- a/backport/backport-include/net/netlink.h
> +++ b/backport/backport-include/net/netlink.h
> @@ -189,4 +189,13 @@ static inline __le64 nla_get_le64(const struct nlattr *nla)
> }
> #endif /* < 4.4 */
>
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,7,0)
> +#define nla_put_u64_64bit LINUX_BACKPORT(nla_put_u64_64bit)
> +static inline int nla_put_u64_64bit(struct sk_buff *skb, int attrtype,
> + u64 value, int padattr)
> +{
> + return nla_put_u64(skb, attrtype, value);
> +}
> +#endif /* < 4.7 */
> +
> #endif /* __BACKPORT_NET_NETLINK_H */
>
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2016-05-31 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 14:07 [PATCH] backports: add nla_put_u64_64bit() Johannes Berg
2016-05-31 19:38 ` Arend van Spriel [this message]
2016-05-31 20:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574DE840.4060009@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox