Re: [PATCH 2/2] backports: add the necessary backports for netlink extack

[Arend Van Spriel <arend.vanspriel@broadcom.com>]

On 21-4-2017 12:47, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>

I did not follow everything about this extack thing, but does it impose
a version requirement on the libnl used in user-space?

> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  backport/backport-include/linux/netlink.h | 17 ++++++++
>  backport/backport-include/net/genetlink.h | 24 +++++++++++
>  backport/backport-include/net/netlink.h   | 69 +++++++++++++++++++++++++++++++
>  patches/0078-genl-extack.cocci            |  5 +++
>  4 files changed, 115 insertions(+)
>  create mode 100644 patches/0078-genl-extack.cocci

[...]

> +/* this is for patches we apply */

Guess the comment is inspired by the one below ;-) but would it not be a
bit more clear to say:

/* this is for files patched using 0078-genl-extack.cocci */

> +static inline struct netlink_ext_ack *genl_info_extack(struct genl_info *info)
> +{
> +#if LINUX_VERSION_IS_GEQ(4,12,0)
> +	return info->extack;
> +#else
> +	return NULL;
> +#endif
> +}
> +
>  /* this is for patches we apply */
>  #if LINUX_VERSION_IS_LESS(3,7,0)
>  #define genl_info_snd_portid(__genl_info) (__genl_info->snd_pid)

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in