From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
barebox@lists.infradead.org, Juergen Borleis <jbe@pengutronix.de>
Subject: Re: [PATCH] ARM: dts. i.MX7: add stopgap solution for barebox UART clock breakage
Date: Mon, 20 Apr 2020 15:10:12 +0200 [thread overview]
Message-ID: <20200420131012.GD1694@pengutronix.de> (raw)
In-Reply-To: <20200415101422.14405-1-a.fatoum@pengutronix.de>
On Wed, Apr 15, 2020 at 12:14:22PM +0200, Ahmad Fatoum wrote:
> Commit 8b2104d740 ("driver: Call of_clk_set_defaults for each probed device")
> made barebox act on the assigned-clock-parents property everywhere, not
> only for clock provider nodes. This breaks at least the serial console on
> the i.MX7 SabreSD board; only garbage is output if the patch is not
> reverted. As stopgap measure, override these properties for all enabled
> uart nodes in the barebox i.MX7 device tree. This reverts the behavior
> to what it was like before the offending commit.
>
> This is of course no real solution, as obviously Linux was fine dealing
> with these properties before. But this hack should at least fix the
> serial console for the boards that were broken in v2020.03.0.
>
> When a proper fix follows, this patch can be reverted.
>
> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Juergen Borleis <jbe@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Hello Sascha,
>
> please apply to master, so the boards broken in v2020.03.0
> aren't broken in v2020.04.0 as well.
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-04-20 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 10:14 [PATCH] ARM: dts. i.MX7: add stopgap solution for barebox UART clock breakage Ahmad Fatoum
2020-04-20 13:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420131012.GD1694@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox