From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [v3] Add throughput meter support
Date: Tue, 03 May 2016 14:32:28 +0200 [thread overview]
Message-ID: <10228266.x0VlN5ZfLu@bentobox> (raw)
In-Reply-To: <5437772.flAExnCRQc@prime>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Tuesday 03 May 2016 13:28:16 Simon Wunderlich wrote:
> On Tuesday 03 May 2016 10:59:07 Sven Eckelmann wrote:
> > Hi,
> >
> > here is the third version of the throughput meter support. It is just a
> > rebased version of the patchset with two little bugfixes. Both problems were
> > detected and reported by Antonio:
> >
> > * batctl didn't check if the test_time is > 0 before doing a division
> > * batman-adv wasn't returning an error to batctl when dst was not reachable
> >
> >
> > I am currently unsure how we should proceed regarding the ICMP packet type
> > used to communicate to the userspace ([PATCH 2/3]). Andrew+Matthias already
> > prepared a netlink patchset which looks quite good and which should be
> > tested+applied. The consequence for this patchset would be that patch 2
> > should be completely dropped and instead the tp_meter should become its own
> > command in the netlink interface of batman-adv. Any opinions about that
> > (order in which patches should be applied/netlink interface should be
> > handled) by the Simon, Antonio, Marek, Matthias or Andrew?
>
> Thanks for preparing the patchset! Antonio, Marek and me discussed and agreed
> that we should adopt the patchset as it is, and have the netlink support
> additionally at a later point.
Did read Antonio the comment in the internal ticket?
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-05-03 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 8:59 [B.A.T.M.A.N.] [v3] Add throughput meter support Sven Eckelmann
2016-05-03 9:00 ` [B.A.T.M.A.N.] [PATCH v3 2/3] batman-adv: use another ICMP packet when sending command from userspace Sven Eckelmann
2016-05-03 9:00 ` [B.A.T.M.A.N.] [PATCH v3 3/3] batman-adv: throughput meter implementation Sven Eckelmann
2016-05-03 9:01 ` [B.A.T.M.A.N.] [PATCH v3] batctl: introduce throughput meter support Sven Eckelmann
2016-05-03 12:28 ` [B.A.T.M.A.N.] [v3] Add " Simon Wunderlich
2016-05-03 12:32 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10228266.x0VlN5ZfLu@bentobox \
--to=sven.eckelmann@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox