public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add DAT cache netlink support
Date: Sun, 04 Mar 2018 13:36:30 +0100	[thread overview]
Message-ID: <10439742.yrGnshK4dX@sven-edge> (raw)
In-Reply-To: <20180227081016.13122-1-linus.luessing@c0d3.blue>

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

> diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
> index 19b15de4..aca34e95 100644
> --- a/net/batman-adv/distributed-arp-table.c
> +++ b/net/batman-adv/distributed-arp-table.c
> @@ -43,13 +43,18 @@
>  #include <linux/string.h>
>  #include <linux/workqueue.h>
>  #include <net/arp.h>
> +#include <net/genetlink.h>
> +#include <net/netlink.h>
> +#include <net/sock.h>
>  
>  #include "bridge_loop_avoidance.h"
>  #include "hard-interface.h"
>  #include "hash.h"
>  #include "log.h"
> +#include "netlink.h"
>  #include "originator.h"
>  #include "send.h"
> +#include "soft-interface.h"
>  #include "translation-table.h"
>  #include "tvlv.h"

Please also add:

* #include <linux/netlink.h> for
  - netlink_callback
  - NETLINK_CB
* #include <uapi/linux/batman_adv.h>
  - for all the new batadv genl attributes

> diff --git a/net/batman-adv/distributed-arp-table.h b/net/batman-adv/distributed-arp-table.h
> index e24aa960..23d11494 100644
> --- a/net/batman-adv/distributed-arp-table.h
> +++ b/net/batman-adv/distributed-arp-table.h

Please also add forward declaration for "struct netlink_callback;" (above 
"struct seq_file;").

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-03-04 12:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27  8:10 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add DAT cache netlink support Linus Lüssing
2018-02-27  8:10 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: add multicast flags " Linus Lüssing
2018-03-04 12:36   ` Sven Eckelmann
2018-03-04 13:36   ` Sven Eckelmann
2018-03-04 12:36 ` Sven Eckelmann [this message]
2018-03-04 16:41 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add DAT cache " Sven Eckelmann
2018-03-04 17:34   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10439742.yrGnshK4dX@sven-edge \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox