From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH maint] batman-adv: mcast: don't send link-local multicast to mcast routers
Date: Sun, 02 Jan 2022 09:24:45 +0100 [thread overview]
Message-ID: <11399690.sF5aMAaoD0@sven-l14> (raw)
In-Reply-To: <20220101052713.9204-1-linus.luessing@c0d3.blue>
[-- Attachment #1.1: Type: text/plain, Size: 902 bytes --]
On Saturday, 1 January 2022 06:27:13 CET Linus Lüssing wrote:
> The addition of routable multicast TX handling introduced a
> bug/regression for packets with a link-local multicast destination:
> These packets would be sent to all batman-adv nodes with a multicast
> router and to all batman-adv nodes with an old version without multicast
> router detection.
>
> This even disregards the batman-adv multicast fanout setting, which can
> potentially lead to an unwanted, high number of unicast transmissions or
> even congestion.
>
> Fixing this by avoiding to send link-local multicast packets to nodes in
> the multicast router list.
>
> Fixes: 3a8df00cd969 ("batman-adv: mcast: apply optimizations for routable packets, too")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
It fails to build. See attachment.
I will fix this myself.
Kind regards,
Sven
[-- Attachment #1.2: Build check errors found: 2022-01-02.zip --]
[-- Type: application/zip, Size: 19331 bytes --]
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-01-02 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 5:27 [PATCH maint] batman-adv: mcast: don't send link-local multicast to mcast routers Linus Lüssing
2022-01-02 8:24 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11399690.sF5aMAaoD0@sven-l14 \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox