From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] alfred: Allow setting the source mac via unix sock
Date: Wed, 17 Feb 2016 09:39:21 +0100 [thread overview]
Message-ID: <11933942.EqGnTx1S2H@bentobox> (raw)
In-Reply-To: <1455666670-32409-1-git-send-email-dominik@heidler.eu>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Wednesday 17 February 2016 00:51:10 Dominik Heidler wrote:
> The alfred client sets the mac to zero by default
> so this shouldn't break existing behaviour.
This also may not to be true. Some users of alfred may not set the source in
alfred_data and thus they may end up with random bytes when reusing a buffer,
allocating a buffer without memset or using an uninitialized buffer on stack.
It is bad practice to send uninitialized bytes around but I just wanted to
point out that potential problem.
Your patch also doesn't explain why this feature may be required.
Btw. you can grep for "data_source" to find the code related to the
sync/forwarded rules of alfred.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-17 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 23:51 [B.A.T.M.A.N.] [PATCH] alfred: Allow setting the source mac via unix sock Dominik Heidler
2016-02-17 8:10 ` Sven Eckelmann
2016-02-17 8:39 ` Sven Eckelmann [this message]
2016-02-17 10:36 ` Dominik Heidler
2016-03-11 15:27 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11933942.EqGnTx1S2H@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox