* [B.A.T.M.A.N.] [PATCH] batman-adv: Use bitwise instead of arithmetic operator for flags
@ 2016-07-11 9:16 Linus Lüssing
2016-07-11 9:38 ` Sven Eckelmann
0 siblings, 1 reply; 3+ messages in thread
From: Linus Lüssing @ 2016-07-11 9:16 UTC (permalink / raw)
To: b.a.t.m.a.n
This silences the following coccinelle warning:
"WARNING: sum of probable bitmasks, consider |"
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
net/batman-adv/multicast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c
index cc91507..894df60 100644
--- a/net/batman-adv/multicast.c
+++ b/net/batman-adv/multicast.c
@@ -528,7 +528,7 @@ update:
}
return !(mcast_data.flags &
- (BATADV_MCAST_WANT_ALL_IPV4 + BATADV_MCAST_WANT_ALL_IPV6));
+ (BATADV_MCAST_WANT_ALL_IPV4 | BATADV_MCAST_WANT_ALL_IPV6));
}
/**
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use bitwise instead of arithmetic operator for flags
2016-07-11 9:16 [B.A.T.M.A.N.] [PATCH] batman-adv: Use bitwise instead of arithmetic operator for flags Linus Lüssing
@ 2016-07-11 9:38 ` Sven Eckelmann
2016-07-15 7:54 ` Marek Lindner
0 siblings, 1 reply; 3+ messages in thread
From: Sven Eckelmann @ 2016-07-11 9:38 UTC (permalink / raw)
To: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Montag, 11. Juli 2016 11:16:36 CEST Linus Lüssing wrote:
> This silences the following coccinelle warning:
>
> "WARNING: sum of probable bitmasks, consider |"
>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> net/batman-adv/multicast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use bitwise instead of arithmetic operator for flags
2016-07-11 9:38 ` Sven Eckelmann
@ 2016-07-15 7:54 ` Marek Lindner
0 siblings, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2016-07-15 7:54 UTC (permalink / raw)
To: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On Monday, July 11, 2016 11:38:19 Sven Eckelmann wrote:
> On Montag, 11. Juli 2016 11:16:36 CEST Linus Lüssing wrote:
> > This silences the following coccinelle warning:
> >
> > "WARNING: sum of probable bitmasks, consider |"
> >
> > Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> > ---
> >
> > net/batman-adv/multicast.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
Applied in revision f0935ab.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-15 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-11 9:16 [B.A.T.M.A.N.] [PATCH] batman-adv: Use bitwise instead of arithmetic operator for flags Linus Lüssing
2016-07-11 9:38 ` Sven Eckelmann
2016-07-15 7:54 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox