From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 7/8] batman-adv: add debugfs structure for information per interface
Date: Thu, 21 Nov 2013 09:38:41 +0800 [thread overview]
Message-ID: <12732164.njm70c9A0l@diderot> (raw)
In-Reply-To: <1384366492-27310-8-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
On Wednesday 13 November 2013 19:14:51 Simon Wunderlich wrote:
> void batadv_debugfs_init(void)
> {
> struct batadv_debuginfo **bat_debug;
> @@ -378,6 +395,11 @@ void batadv_debugfs_init(void)
> if (!batadv_debugfs)
> goto err;
>
> + batadv_hardif_debugfs =
> debugfs_create_dir(BATADV_DEBUGFS_HARDIF_SUBDIR,
> + batadv_debugfs);
> + if (batadv_hardif_debugfs == ERR_PTR(-ENODEV))
> + goto err;
> +
> for (bat_debug = batadv_general_debuginfos; *bat_debug; ++bat_debug)
> { file = debugfs_create_file(((*bat_debug)->attr).name, S_IFREG |
> ((*bat_debug)->attr).mode,
I see no specific reason to create a 'hardif' subdirectory. We developers may
know what the term relates to but it is reasonable to assume our users do not.
How about adding the interface directory (e.g. wlan0) right next to the batX
directory ? For clarity we could also move the interface directory into the
corresponding batX folder. In case multiple batX interfaces it might makes
things more obvious.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-11-21 1:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 18:14 [B.A.T.M.A.N.] [PATCHv3 0/8] add network wide multi interface optimization Simon Wunderlich
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 1/8] batman-adv: remove bonding and interface alternating Simon Wunderlich
2013-11-21 1:23 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 2/8] batman-adv: split tq information in neigh_node struct Simon Wunderlich
2013-11-21 1:25 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 3/8] batman-adv: split out router from orig_node Simon Wunderlich
2013-11-21 1:26 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 4/8] batman-adv: add WiFi penalty Simon Wunderlich
2013-11-21 1:28 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 5/8] batman-adv: consider outgoing interface in OGM sending Simon Wunderlich
2013-11-21 1:29 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 6/8] batman-adv: add bonding again Simon Wunderlich
2013-11-21 1:31 ` Marek Lindner
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 7/8] batman-adv: add debugfs structure for information per interface Simon Wunderlich
2013-11-21 1:38 ` Marek Lindner [this message]
2013-11-21 13:22 ` Simon Wunderlich
2013-11-13 18:14 ` [B.A.T.M.A.N.] [PATCHv3 8/8] batman-adv: add debugfs support to view multiif tables Simon Wunderlich
2013-11-21 1:41 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12732164.njm70c9A0l@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox