From: "Linus Lüssing" <linus.luessing@ascom.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@ascom.ch>
Subject: [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: Send neighbor discovery packets
Date: Tue, 14 Dec 2010 10:58:10 +0100 [thread overview]
Message-ID: <1292320696-11983-5-git-send-email-linus.luessing@ascom.ch> (raw)
In-Reply-To: <1292320696-11983-1-git-send-email-linus.luessing@ascom.ch>
This patch makes use of the previously introduced periodic tasks per
interface and actually sends neighbor discovery packets on these now.
Note: The TQ values of each neighbor are not being added yet to these NDPs
and also no evaluation of these packets is being done.
Signed-off-by: Linus Lüssing <linus.luessing@ascom.ch>
---
hard-interface.c | 5 ++++-
ndp.c | 36 +++++++++++++++++++++++++++++++++++-
types.h | 5 +++++
3 files changed, 44 insertions(+), 2 deletions(-)
diff --git a/hard-interface.c b/hard-interface.c
index cb81c13..887f794 100644
--- a/hard-interface.c
+++ b/hard-interface.c
@@ -284,6 +284,7 @@ int hardif_enable_interface(struct batman_if *batman_if, char *iface_name)
{
struct bat_priv *bat_priv;
struct batman_packet_ogm *batman_packet_ogm;
+ int ret;
if (batman_if->if_status != IF_NOT_IN_USE)
goto out;
@@ -331,7 +332,9 @@ int hardif_enable_interface(struct batman_if *batman_if, char *iface_name)
atomic_set(&batman_if->seqno, 1);
atomic_set(&batman_if->frag_seqno, 1);
- ndp_init(batman_if);
+ ret = ndp_init(batman_if);
+ if (ret)
+ goto err;
bat_info(batman_if->soft_iface, "Adding interface: %s\n",
batman_if->net_dev->name);
diff --git a/ndp.c b/ndp.c
index 2dfb06d..94d1971 100644
--- a/ndp.c
+++ b/ndp.c
@@ -20,10 +20,21 @@ static void ndp_send(struct work_struct *work)
struct batman_if *batman_if = container_of(work, struct batman_if,
ndp_wq.work);
struct bat_priv *bat_priv = netdev_priv(batman_if->soft_iface);
+ struct batman_packet_ndp *ndp_packet;
+ struct sk_buff *skb;
+
+ skb = skb_clone(batman_if->ndp_skb, GFP_ATOMIC);
+ ndp_packet = (struct batman_packet_ndp*)skb->data;
+ ndp_packet->seqno = htonl(atomic_read(&batman_if->ndp_seqno));
+ ndp_packet->num_neighbors = 0;
+ memcpy(ndp_packet->orig, bat_priv->primary_if->net_dev->dev_addr,
+ ETH_ALEN);
bat_dbg(DBG_BATMAN, bat_priv,
"batman-adv:Sending ndp packet on interface %s, seqno %d\n",
- batman_if->net_dev, atomic_read(&batman_if->ndp_seqno));
+ batman_if->net_dev, ntohl(ndp_packet->seqno));
+
+ send_skb_packet(skb, batman_if, broadcast_addr);
atomic_inc(&batman_if->ndp_seqno);
start_ndp_timer(batman_if);
@@ -31,14 +42,37 @@ static void ndp_send(struct work_struct *work)
int ndp_init(struct batman_if *batman_if)
{
+ struct batman_packet_ndp *ndp_packet;
+
atomic_set(&batman_if->ndp_interval, 500);
atomic_set(&batman_if->ndp_seqno, 0);
+
+ batman_if->ndp_skb =
+ dev_alloc_skb(ETH_DATA_LEN + sizeof(struct ethhdr));
+ if (!batman_if->ndp_skb) {
+ printk(KERN_ERR "batman-adv: Can't add "
+ "local interface packet (%s): out of memory\n",
+ batman_if->net_dev->name);
+ goto err;
+ }
+ skb_reserve(batman_if->ndp_skb, sizeof(struct ethhdr) +
+ sizeof(struct batman_packet_ndp));
+ ndp_packet = (struct batman_packet_ndp*)
+ skb_push(batman_if->ndp_skb, sizeof(struct batman_packet_ndp));
+ memset(ndp_packet, 0, sizeof(struct batman_packet_ndp));
+
+ ndp_packet->packet_type = BAT_PACKET_NDP;
+ ndp_packet->version = COMPAT_VERSION;
+
INIT_DELAYED_WORK(&batman_if->ndp_wq, ndp_send);
return 0;
+err:
+ return 1;
}
void ndp_free(struct batman_if *batman_if)
{
stop_ndp_timer(batman_if);
+ dev_kfree_skb(batman_if->ndp_skb);
}
diff --git a/types.h b/types.h
index e8dfdf6..c5a26a7 100644
--- a/types.h
+++ b/types.h
@@ -49,6 +49,7 @@ struct batman_if {
struct rcu_head rcu;
atomic_t ndp_interval;
atomic_t ndp_seqno;
+ struct sk_buff *ndp_skb;
struct delayed_work ndp_wq;
};
@@ -122,6 +123,10 @@ struct neigh_node {
struct batman_if *if_incoming;
};
+struct neigh_entry {
+ uint8_t addr[ETH_ALEN];
+ uint8_t rq;
+};
struct bat_priv {
atomic_t mesh_state;
--
1.7.1
next prev parent reply other threads:[~2010-12-14 9:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 9:58 [B.A.T.M.A.N.] NDP patches v3 Linus Lüssing
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Creating new neighbor discovery packet Linus Lüssing
2010-12-21 17:39 ` Marek Lindner
2010-12-21 18:01 ` Andrew Lunn
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: Adding jittering methods for ndp Linus Lüssing
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Adding workqueue for new ndp packets Linus Lüssing
2010-12-21 23:52 ` Marek Lindner
2010-12-14 9:58 ` Linus Lüssing [this message]
2010-12-22 13:43 ` [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: Send neighbor discovery packets Marek Lindner
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 05/10] batman-adv: Creating neighbor structures, updating LQs Linus Lüssing
2010-12-15 17:09 ` [B.A.T.M.A.N.] linearize skb earlier Linus Lüssing
2010-12-15 17:09 ` [B.A.T.M.A.N.] [PATCHv2 05/10] batman-adv: Creating neighbor structures, updating LQs Linus Lüssing
2010-12-28 13:59 ` Marek Lindner
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 06/10] batman-adv: Purge outdated ndp neighbours Linus Lüssing
2010-12-28 14:09 ` Marek Lindner
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 07/10] batman-adv: Adding ndp debugfs output Linus Lüssing
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 08/10] batman-adv: Adding batman_if specific sysfs wrapper macros for UINT Linus Lüssing
2010-12-28 15:14 ` Marek Lindner
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 09/10] batman-adv: Adding sysfs parameter for ndp interval Linus Lüssing
2010-12-14 9:58 ` [B.A.T.M.A.N.] [PATCH 10/10] batman-adv: Use local tq values determined by NDP on OGMs Linus Lüssing
-- strict thread matches above, loose matches on Subject: below --
2010-12-07 14:39 [B.A.T.M.A.N.] NDP patches, first draft Linus Lüssing
2010-12-07 14:39 ` [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: Send neighbor discovery packets Linus Lüssing
2010-12-07 14:51 ` Sven Eckelmann
2010-12-07 20:23 ` Linus Lüssing
2010-12-09 9:23 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292320696-11983-5-git-send-email-linus.luessing@ascom.ch \
--to=linus.luessing@ascom.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox